refactor: add validation to project blueprints #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
Panaetius
force-pushed
the
refactor/304-add-validation-to-namespaces
branch
from
b5b9b54 to
274052e
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
4694d00 to
f49cd19
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-namespaces
branch
from
274052e to
be18fd1
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
f49cd19 to
24bc452
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-namespaces
branch
from
be18fd1 to
e15f658
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
24bc452 to
d21d12a
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-namespaces
branch
from
e15f658 to
fc708bd
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
d21d12a to
c858d50
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-namespaces
branch
from
fc708bd to
c0912b7
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
5 times, most recently
from
fb54287 to
340974f
Compare
This was referenced Aug 9, 2024
olevski
requested changes
Aug 12, 2024
Comment on lines
47
to
48
| @dataclass(frozen=True, eq=True, kw_only=True) | ||
| class UnsavedSessionLauncher(BaseModel): |
Member
There was a problem hiding this comment.
suggestion: Same as above there is no reason to use pydantic here. The model validator below can just be a dataclass __post_init__ method.
Member
There was a problem hiding this comment.
Panaetius
force-pushed
the
refactor/304-add-validation-to-namespaces
branch
from
c0912b7 to
f9e1096
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
340974f to
c5c79ac
Compare
Base automatically changed from
refactor/304-add-validation-to-namespaces
to
main
August 12, 2024 13:31
Panaetius
changed the base branch from
main
to
refactor/304-add-ulid-type-to-db-models
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
c5c79ac to
9fa160e
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-type-to-db-models
branch
from
e7932fc to
56d6b86
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
9fa160e to
405c2e8
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-type-to-db-models
branch
from
56d6b86 to
5a32c11
Compare
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
405c2e8 to
1f06994
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-type-to-db-models
branch
from
5a32c11 to
b54659b
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
1f06994 to
ed94ebe
Compare
Panaetius
changed the base branch from
refactor/304-add-ulid-type-to-db-models
to
refactor/304-add-validation-to-repos-sessions-storage
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
ed94ebe to
aa80d4a
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
from
8dbfc73 to
4803f45
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-projects
branch
from
aa80d4a to
def8f59
Compare
Panaetius
merged commit def8f59
into
refactor/304-add-validation-to-repos-sessions-storage
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.