Merge data connectors and notebooks/amalthea migration #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the `project_slugs` table to `entity_slugs` and `project_slugs_old` to `entity_slugs_old`. This is done to prepare for more entity types to be namespaced. Note: the sequence migration has been tested: 1. Force migration revision to be `9058bf0a1a12` (before this). 2. Deploy with image tag `renku/renku-data-service:sha-345a1bb` (current `main`) and run `alembic check` and `alembic heads` to verify the DB is before this change. 3. Create some projects. 4. Re-deploy this PR and check that migration revision is `a11752a5afba` (after this). 5. Create more projects.
Introduce namespaced data connectors for Renku 2.0. Details: * Remove API routes for `/storages_v2` * Add API routes for `/data_connectors` * Add `data_connectors` table * Drop the `storage_secrets` table * Add `data_connectors_secrets` table
Fixes deleting storage configuration fields by setting them to `null`.
…to leafty/feat-namespaced-data-connectors-3 # Conflicts: # test/bases/renku_data_services/data_api/test_data_connectors.py
…ectors-3' into leafty/feat-namespaced-data-connectors-4
…ectors-4' into leafty/feat-namespaced-data-connectors-5
…ectors-4' into leafty/feat-namespaced-data-connectors-5
leafty
temporarily deployed
to
renku-ci-ds-428
GitHub Actions
Inactive
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-428.dev.renku.ch |
leafty
temporarily deployed
to
renku-ci-ds-428
GitHub Actions
Inactive
olevski
force-pushed
the
feat-add-cloudstorage
branch
2 times, most recently
from
bf8efeb to
04553ec
Compare
Co-authored-by: Samuel Gaist <[email protected]>
Base automatically changed from
feat-add-cloudstorage
to
release-amaltheas-migration
September 27, 2024 14:01
…o leafty/feat-namespaced-data-connectors-merge-amalthea-migration # Conflicts: # Makefile # bases/renku_data_services/data_api/app.py # components/renku_data_services/notebooks/api.spec.yaml # components/renku_data_services/notebooks/api/classes/k8s_client.py # components/renku_data_services/notebooks/api/classes/server.py # components/renku_data_services/notebooks/api/classes/server_manifest.py # components/renku_data_services/notebooks/api/schemas/servers_get.py # components/renku_data_services/notebooks/apispec.py # components/renku_data_services/notebooks/blueprints.py # components/renku_data_services/session/api.spec.yaml # components/renku_data_services/storage/blueprints.py # components/renku_data_services/storage/models.py # poetry.lock # projects/renku_data_service/pyproject.toml # projects/secrets_storage/pyproject.toml # test/bases/renku_data_services/data_api/test_sessions.py
leafty
had a problem deploying
to
renku-ci-ds-428
GitHub Actions
Failure
leafty
had a problem deploying
to
renku-ci-ds-428
GitHub Actions
Failure
leafty
had a problem deploying
to
renku-ci-ds-428
GitHub Actions
Failure
…o leafty/feat-namespaced-data-connectors-merge-amalthea-migration
olevski
force-pushed
the
release-amaltheas-migration
branch
from
7fcfa17 to
be5272b
Compare
leafty
had a problem deploying
to
renku-ci-ds-428
GitHub Actions
Failure
leafty
had a problem deploying
to
renku-ci-ds-428
GitHub Actions
Failure
olevski
force-pushed
the
release-amaltheas-migration
branch
5 times, most recently
from
d2b2d48 to
a932966
Compare
olevski
force-pushed
the
release-amaltheas-migration
branch
2 times, most recently
from
b2532b4 to
62e197a
Compare
olevski
force-pushed
the
release-amaltheas-migration
branch
from
91b8e88 to
ea89929
Compare
leafty
deleted the
leafty/feat-namespaced-data-connectors-merge-amalthea-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Merges:
Currently working:
/deploy renku=feat-jupyter-free-sessions amalthea-sessions=feat-add-cloud-storage renku-notebooks=master renku-gateway=feat-add-renku-refresh-token-for-data-service renku-ui=build/data-connectors extra-values=amalthea-sessions.deployCrd=false,amalthea-sessions.rcloneStorageClass=csi-rclone-387-secret-annotation #notest