Skip to content

fix: ignore jupyterservers if the CRD is not found #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leafty merged 1 commit into from
Aug 26, 2025
Merged

fix: ignore jupyterservers if the CRD is not found #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/k8s/jupyterserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"

k8serrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/dynamic"
Expand Down Expand Up @@ -51,7 +52,10 @@ func DeleteJupyterServers(ctx context.Context, client *dynamic.DynamicClient, na

propagation := metav1.DeletePropagationBackground
err := client.Resource(*gvr).Namespace(namespace).DeleteCollection(ctx, metav1.DeleteOptions{PropagationPolicy: &propagation}, metav1.ListOptions{})
if err != nil {
if err != nil && k8serrors.IsNotFound(err) {
fmt.Printf("Warning: Resource not found: %s\n", gvr.String())
return nil
} else if err != nil {
return err
}
return nil
Expand Down Expand Up @@ -82,7 +86,13 @@ func ForciblyDeleteJupyterServer(ctx context.Context, client *dynamic.DynamicCli

func ForciblyDeleteJupyterServers(ctx context.Context, client *dynamic.DynamicClient, namespace string, gvr *schema.GroupVersionResource) error {
servers, err := ListJupyterServers(ctx, client, namespace, gvr)
if err != nil {
if err != nil && k8serrors.IsNotFound(err) {
if gvr == nil {
gvr = &jupyterServerGroupVersionResource
}
fmt.Printf("Warning: Resource not found: %s\n", gvr.String())
return nil
} else if err != nil {
return err
}

Expand Down