Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
run: |
sudo apt install libx11-dev

- name: golangci-lint
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v9
with:
version: v2.1
version: v2.6
4 changes: 4 additions & 0 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## Linting

Developers need to manually install `golangci-lint`.
See: https://golangci-lint.run/docs/welcome/install/.
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ check-format: ## Check that sources are correctly formatted
check-vet: ## Check source files with `go vet`
go vet ./...

.PHONY: lint
lint: ## Lint source files with `golangci-lint run`
golangci-lint run

##@ Code generation

.PHONY: renku-users-apispec
Expand All @@ -80,8 +84,6 @@ renku-users-apispec: ## Download the "users" API spec
.PHONY: renku-session-apispec
renku-session-apispec: ## Download the "session" API spec
curl -L -o pkg/renkuapi/session/api.spec.yaml https://raw.githubusercontent.com/SwissDataScienceCenter/renku-data-services/refs/heads/main/components/renku_data_services/session/api.spec.yaml
# sed -e 's/- default: "general"//g' pkg/renkuapi/users/api.spec.yaml > pkg/renkuapi/users/api.spec.new.yaml
# mv pkg/renkuapi/users/api.spec.new.yaml pkg/renkuapi/users/api.spec.yaml

.PHONY: generate
generate: pkg/renkuapi/users/users_gen.go pkg/renkuapi/session/session_gen.go ## Run go generate
Expand Down