Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Run tests

# Trigger on push
on:
push:

permissions:
contents: read

defaults:
run:
shell: bash

jobs:
test:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.24.2'
check-latest: true

- name: Install libraries for ubuntu
run: |
sudo apt install libx11-dev

- name: Print environment
run: |
which go
go env
make vars

- name: Check format
run: make check-format

- name: Check vet
run: make check-vet

- name: Build renku-dev-utils
run: make rdu
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,11 @@ help: ## Display this help.
.PHONY: format
format: ## Format source files
gofmt -l -w .

.PHONY: check-format
check-format: ## Check that sources are correctly formatted
gofmt -d -s . && git diff --exit-code

.PHONY: check-vet
check-vet: ## Check source files with `go vet`
go vet ./...
2 changes: 1 addition & 1 deletion pkg/k8s/amaltheasession.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func ForciblyDeleteAmaltheaSessions(ctx context.Context, client *dynamic.Dynamic
for _, server := range servers {
err = ForciblyDeleteAmaltheaSession(ctx, client, namespace, server, gvr)
if err != nil {
fmt.Printf("Ignoring error: %w\n", err)
fmt.Printf("Ignoring error: %s\n", err)
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/k8s/jupyterserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func ForciblyDeleteJupyterServers(ctx context.Context, client *dynamic.DynamicCl
for _, server := range servers {
err = ForciblyDeleteJupyterServer(ctx, client, namespace, server, gvr)
if err != nil {
fmt.Printf("Ignoring error: %w\n", err)
fmt.Printf("Ignoring error: %s\n", err)
}
}

Expand Down