feat: allow data connectors to be skipped when launching sessions #3873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Works great and the code looks already good 🚀
I'll approve after reverting the script change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: SwissDataScienceCenter/renku-data-services#1065.
The data-service API is changed to allow not mounting data connectors at session launch. With this change, the "Skip" action now means "do not mount this data connector", which is what Renku should do in most cases (trying to mount without credentials or with invalid credentials leads to session nodes being banned e.g. from SFTP hosts).
Updated modal:
Skipping will not mount:
