Implement extra properties/soft-deleting features #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
npavlyk82
force-pushed
the
npav/storeExtraProperties
branch
2 times, most recently
from
e423582 to
05449a7
Compare
gmiserez
requested changes
Feb 10, 2025
| BewitToken<TPayload> bewit | ||
| = await tokenGenerator.GenerateBewitTokenAsync(result, context.RequestAborted); | ||
| = await tokenGenerator.GenerateBewitTokenAsync( | ||
| result, context.RequestAborted, context.GetBewitTokenExtraProperties()); |
Collaborator
There was a problem hiding this comment.
cancellationtoken should be the last parameter
| BewitToken<string> bewit = | ||
| await tokenGenerator.GenerateBewitTokenAsync( | ||
| uri.PathAndQuery, context.RequestAborted); | ||
| uri.PathAndQuery, context.RequestAborted, context.GetBewitTokenExtraProperties()); |
Collaborator
There was a problem hiding this comment.
cancellationToken should be the last parameter
| public async ValueTask InsertOneAsync( | ||
| Token token, CancellationToken cancellationToken) | ||
| { | ||
| if (token.ExtraProperties != null) |
Collaborator
There was a problem hiding this comment.
we should not create indexes in CRUD methods, as this doubles our calls to the mongoDB.
If the extra properties can not be prediced on startup, we should skip index creations for them altogether.
Contributor
Author
There was a problem hiding this comment.
I would leave it as is. The MongoDB.Driver is smart enough:
- it makes a call on GetCollection and caches all index info on the client.
- It doesn't make an additional call if we try to create an already existing index.
- _collection.Indexes.CreateOne doesn't create the index immediately; it will be done on the server side asynchronously.
Contributor
Author
There was a problem hiding this comment.
I have changed the logic. The indexes can be created for values of primitive types. The complex type values will be sterilized to json string
| _collection.Indexes.CreateOne(new CreateIndexModel<Token>( | ||
| Builders<Token>.IndexKeys.Ascending(nameof(IdentifiableToken.Identifier)))); | ||
|
|
||
| _collection.Indexes.CreateOne(new CreateIndexModel<Token>( |
Collaborator
There was a problem hiding this comment.
compound index can be removed (nonce being already unique)
npavlyk82
force-pushed
the
npav/storeExtraProperties
branch
2 times, most recently
from
9811d7c to
14ad842
Compare
npavlyk82
force-pushed
the
npav/storeExtraProperties
branch
from
14ad842 to
2e39409
Compare
gmiserez
previously approved these changes
Feb 11, 2025
gmiserez
previously approved these changes
Feb 11, 2025
npavlyk82
force-pushed
the
npav/storeExtraProperties
branch
from
ad2428a to
bb2ec06
Compare
gmiserez
previously approved these changes
Feb 11, 2025
gmiserez
previously approved these changes
Feb 11, 2025
gmiserez
previously approved these changes
Feb 12, 2025
npavlyk82
force-pushed
the
npav/storeExtraProperties
branch
from
4cfb51a to
aae8ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22