-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Enable drag-and-drop tasks to agenda to create timed and all-day events #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f2ea0b6
Initial plan
Copilot d1d7223
Implement task to event conversion and migrate tasks to dnd-kit
Copilot e1f9339
Pass dateInView to useEventDNDActions for correct event timing
Copilot 2bc3ae7
Fix DraggableTask tests after migrating to dnd-kit
Copilot 1f89668
Address code review feedback: improve code clarity and documentation
Copilot 4b49359
Address code review feedback: use Schema_Event_Regular type, restore …
Copilot 81ebc37
Use Schema_Event instead of Schema_Event_Regular for return type
Copilot dc5a0b8
Infer dateInView from URL context and create task mock utility
Copilot abaed15
Address PR review: move mock utility, fix Task naming, add allday sup…
Copilot 68a730a
Add error handling for task-to-event conversion and move mock utility…
Copilot a23883e
Fix code review issues: import Task type, fix race condition, prevent…
Copilot 12a1430
Merge remote-tracking branch 'origin/main' into copilot/add-dnd-task-…
Copilot c89b828
Refactor error handling: remove ref/useEffect, extract logic to teste…
Copilot 5af5d6e
Remove doc comment and replace TODO with explanation of current approach
Copilot ee85d21
Address code review: restore task.test.util.ts, simplify conditionals…
Copilot 35691f3
Fix missing getSnappedMinutes import in useEventDNDActions
Copilot 2be21b3
Merge remote-tracking branch 'origin/main' into copilot/add-dnd-task-…
Copilot dbec324
Rename handleTaskToEventConversion to task.util and merge latest from…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { faker } from "@faker-js/faker"; | ||
| import { Task } from "@web/common/types/task.types"; | ||
|
|
||
| /** | ||
| * Creates a mock task with optional overrides | ||
| * @param overrides - Partial task properties to override defaults | ||
| * @returns A complete Task object | ||
| */ | ||
| export function createMockTask(overrides: Partial<Task> = {}): Task { | ||
| return { | ||
| id: faker.string.uuid(), | ||
| title: faker.lorem.sentence({ min: 3, max: 5 }), | ||
| status: "todo", | ||
| order: faker.number.int({ min: 0, max: 100 }), | ||
| createdAt: faker.date.recent().toISOString(), | ||
| ...overrides, | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.