chore(core): Remove flaky timer tests and dead code #1403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
timer.test.tssuite was intermittently failing in CI due to timing-sensitive test assertions. The Timer class was dead code—only used in its own tests.Changes:
packages/core/src/util/timer.baktest.ts(renamed test file)packages/core/src/util/timer.ts(Timer class implementation)packages/core/src/util/wait-until-event.util.tsto remove Timer from type unionThe Timer type was only used for TypeScript type checking in
waitUntilEvent, not runtime functionality. All 233 test suites pass.Original prompt
timer.ts&timer.test.ts#1384💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.