Merged
Conversation
This removes the isFocused props, resolving devtools error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #284
This pull request introduces several changes to the
packages/webproject, focusing on the addition of anIconProvidercomponent, refactoring of icon-related code, and minor improvements to the event form's date pickers.Icon Provider and Related Refactoring:
IconProvidercomponent to manage icon context and size (packages/web/src/components/IconProvider/IconProvider.tsx).RootRouterwithIconProviderin theAppcomponent (packages/web/src/App.tsx). [1] [2]iconStylesby removing theisFocusedprop and usingIconPropsinstead (packages/web/src/components/Icons/styled.ts).sizeandisFocusedprops, utilizing the newIconProviderfor consistent icon sizing and color management (packages/web/src/views/Calendar/components/Dedication/Dedication.tsx,packages/web/src/views/Calendar/components/Header/Header.tsx,packages/web/src/views/Calendar/components/Sidebar/SidebarIconRow/SidebarIconRow.tsx). [1] [2] [3] [4]Minor Improvements:
DatePickerscomponent (packages/web/src/views/Forms/EventForm/DateTimeSection/DatePickers/DatePickers.tsx). [1] [2]useRefimport fromDateTimeSectioncomponent (packages/web/src/views/Forms/EventForm/DateTimeSection/DateTimeSection.tsx).These changes enhance the consistency and maintainability of the icon usage across the application and improve the code quality in the event form components.