✨ Feat: Include recurring events during import#295
Merged
tyler-dane merged 8 commits intomainfrom Mar 12, 2025
Merged
Conversation
00ce7f5 to
bbc4b30
Compare
- Add checks to block editing of recurring events in GridContextMenu, GridEvent, and AllDayEvent - Display an asterisk (*) for recurring events - Show alert when attempting to edit recurring events
…en creating events
strictly types recurrence and event schema
Although these params would've helped narrow down the events needed to import, they'd prevent us from receiving a nextSyncToken, which would break sync. There are several query parameters that cannot be specified together with nextSyncToken to ensure consistency of the client state. See `syncToken` description here: https://developers.google.com/calendar/api/v3/reference/events/list
4b719f0 to
02bbc98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Recurring Events (readonly, first-time import)
This PR is the first step to getting recurring events to work in Compass. It does so by updating how events are imported to include recurring events.
Here is the relevant code for that:
Since we're not allowing users to edit recurring events in Compass, this PR also updates the UI to prevent a user from opening to form, dragging, or resizing a recurring event.
Recurring events are distinguished on the UI with a * to make it easier for users to understand not to click them (yet).
Demo-Recurring.mov
TypeScript improvements
More strictly types event schemas
Closes #293 and #294.
Usage
The changes in this PR will only take effect if you signed up for Compass using this code. If you signed up for Compass locally in development before, we will not import your recurring events as part of this PR. This PR only focuses on getting recurring events to import during the initial sign up process, which involves importing all of a user's events.
TL;DR - To get this to work in local dev, use a new test account or delete the data from your existing account using CLIso you can sign up again.
If you're still having issues, try manually logging out by going to
/logoutand trying again.