Inventory View System #646
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is great for distinction between GUIEvents and View handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, modular GUI framework for the project for stateful, interactive inventory views. It's built in the modern "React" component kind of way, where things are updated when needed.
Currently includes a command
/debugviewto see an example GUI built with the system. There is still some things that need to be done, like checking most different types of GUIs with this system, addingViewContext#pushand#popfor navigation between pages.This PR solves issues with the previous system where sometimes items are missing from the GUI which causes unreliability.
This is system will not completely replace the old GUI system immediately, as there's a lot of GUIs that would have to be migrated. It would be a thing that happens slowly. Also the structure of this system will most likely change a lot until Swofty agrees with it