Merge pull request #7 from Syax89/claude/code-review-testing-o31VM

Release v1.4.9: Use ECU odometer as primary, reduce trip lookback to …

Author: Syax89

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project are documented in this file.
 
+## [1.4.9] - 2026-03-14
+
+### Changed
+- **Odometer Source**: Switched primary odometer to `DiagnosticOdometerId` (ECU-reported, lightweight, updated at ignition on/off). The previous `DiagnosticOdometerAdjustmentId` (hybrid ECM+GPS, expensive API call, can drift over time) is now a diagnostic fallback sensor.
+- **Trip Lookback**: Reduced trip history fetch window from 90 to 30 days. All trip stats (daily/weekly/monthly) only use the last 30 days, so the extra 60 days of data was unnecessary API overhead.
+- **Sensor Renamed**: `odometer_raw` sensor renamed to `odometer_adjustment` to accurately reflect its data source (Geotab's hybrid adjustment value, not raw ECU data).
+
 ## [1.4.8] - 2026-03-14
 
 ### Fixed

custom_components/geotab/api.py

@@ -145,7 +145,7 @@ def _blocking_fetch_all(self, include_trips: bool = True) -> tuple[list, list, l
 
         # Trips (only when include_trips=True)
         if include_trips:
-            from_date = (datetime.now(timezone.utc) - timedelta(days=90)).isoformat()
+            from_date = (datetime.now(timezone.utc) - timedelta(days=30)).isoformat()
             for device in devices:
                 device_id = device["id"]
                 calls.append(
@@ -315,11 +315,10 @@ async def async_get_full_device_data(
                     data.update(diag_data)
 
                     # Robust fallback for odometer
+                    # Priority: OdometerId (ECU, lightweight) → AdjustmentId (hybrid) → TotalDistance (GPS)
                     if not data.get("odometer"):
                         if diag_data.get("odometer_adjustment"):
                             data["odometer"] = diag_data["odometer_adjustment"]
-                        elif diag_data.get("odometer_raw"):
-                            data["odometer"] = diag_data["odometer_raw"]
                         elif diag_data.get("total_distance"):
                             data["odometer"] = diag_data["total_distance"]
 

custom_components/geotab/const.py

@@ -26,8 +26,8 @@
 # Define the diagnostics we want to fetch, grouped by category
 DIAGNOSTICS_TO_FETCH = {
     # Driving & odometer
-    "odometer": "DiagnosticOdometerAdjustmentId",
-    "odometer_raw": "DiagnosticOdometerId",
+    "odometer": "DiagnosticOdometerId",
+    "odometer_adjustment": "DiagnosticOdometerAdjustmentId",
     "total_distance": "DiagnosticTotalDistanceId",
     "ignition": "DiagnosticIgnitionId",
     # Energy & fuel

custom_components/geotab/manifest.json

@@ -7,6 +7,6 @@
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/Syax89/geotab-hacs-integration/issues",
   "requirements": ["mygeotab>=0.9.1,<1.0.0"],
-  "version": "1.4.8"
+  "version": "1.4.9"
 }
 

custom_components/geotab/sensor.py

@@ -60,16 +60,16 @@ class GeotabSensorEntityDescription(SensorEntityDescription):
         ),
     ),
     GeotabSensorEntityDescription(
-        key="odometer_raw",
-        translation_key="odometer_raw",
+        key="odometer_adjustment",
+        translation_key="odometer_adjustment",
         icon="mdi:counter",
         native_unit_of_measurement=UnitOfLength.KILOMETERS,
         device_class=SensorDeviceClass.DISTANCE,
         state_class=SensorStateClass.TOTAL_INCREASING,
         entity_category=EntityCategory.DIAGNOSTIC,
         suggested_display_precision=1,
         value_fn=lambda data: (
-            data.get("odometer_raw", 0) / 1000 if data.get("odometer_raw") is not None else None
+            data.get("odometer_adjustment", 0) / 1000 if data.get("odometer_adjustment") is not None else None
         ),
         entity_registry_enabled_default=False,
     ),

custom_components/geotab/strings.json

@@ -25,7 +25,7 @@
   "entity": {
     "sensor": {
       "odometer": { "name": "Odometer" },
-      "odometer_raw": { "name": "Odometer (Raw)" },
+      "odometer_adjustment": { "name": "Odometer (Adjustment)" },
       "total_distance": { "name": "Odometer (Total Distance)" },
       "fuel_level": { "name": "Fuel Level" },
       "fuel_level_raw": { "name": "Fuel Level (Raw)" },

custom_components/geotab/translations/de.json

@@ -25,7 +25,7 @@
   "entity": {
     "sensor": {
       "odometer": { "name": "Kilometerzähler" },
-      "odometer_raw": { "name": "Kilometerzähler (Rohdaten)" },
+      "odometer_adjustment": { "name": "Kilometerzähler (Anpassung)" },
       "total_distance": { "name": "Kilometerzähler (Gesamtstrecke)" },
       "fuel_level": { "name": "Kraftstoffstand" },
       "fuel_level_raw": { "name": "Kraftstoffstand (Rohdaten)" },

custom_components/geotab/translations/en.json

@@ -25,7 +25,7 @@
   "entity": {
     "sensor": {
       "odometer": { "name": "Odometer" },
-      "odometer_raw": { "name": "Odometer (Raw ECU Data)" },
+      "odometer_adjustment": { "name": "Odometer (Adjustment)" },
       "total_distance": { "name": "Odometer (Total Distance)" },
       "fuel_level": { "name": "Fuel Level" },
       "fuel_level_raw": { "name": "Fuel Level (Raw Data)" },

custom_components/geotab/translations/es.json

@@ -25,7 +25,7 @@
   "entity": {
     "sensor": {
       "odometer": { "name": "Odómetro" },
-      "odometer_raw": { "name": "Odómetro (Datos brutos)" },
+      "odometer_adjustment": { "name": "Odómetro (Ajuste)" },
       "total_distance": { "name": "Odómetro (Distancia total)" },
       "fuel_level": { "name": "Nivel de combustible" },
       "fuel_level_raw": { "name": "Nivel de combustible (Datos brutos)" },

custom_components/geotab/translations/fr.json

@@ -25,7 +25,7 @@
   "entity": {
     "sensor": {
       "odometer": { "name": "Odomètre" },
-      "odometer_raw": { "name": "Odomètre (Données brutes)" },
+      "odometer_adjustment": { "name": "Odomètre (Ajustement)" },
       "total_distance": { "name": "Odomètre (Distance totale)" },
       "fuel_level": { "name": "Niveau de carburant" },
       "fuel_level_raw": { "name": "Niveau de carburant (Données brutes)" },