[Maintenance] Add TestApplication#456
Merged
GSadee merged 10 commits intoSylius:feature/add_test_applicationfrom Jul 2, 2025
Merged
Conversation
Cholin2000
force-pushed
the
feature/introduce_test_application_in_the_plugin_skeleton
branch
from
b86cdba to
effdcae
Compare
Cholin2000
force-pushed
the
feature/introduce_test_application_in_the_plugin_skeleton
branch
from
ea91a1b to
9b036d2
Compare
GSadee
reviewed
Jul 2, 2025
| "symfony/web-profiler-bundle": "^6.4 || ^7.1", | ||
| "symfony/webpack-encore-bundle": "^2.2" | ||
| "symfony/webpack-encore-bundle": "^2.2", | ||
| "symfony/runtime": "^6.4" |
Comment on lines
+73
to
+74
| "minimum-stability": "alpha", | ||
| "prefer-stable": true |
Member
There was a problem hiding this comment.
I would be for not changing the minimum-stability, but install ^2.0.0@alpha of sylius/test-application
| "sylius-labs/coding-standard": "^4.4", | ||
| "sylius-labs/suite-tags-extension": "~0.2", | ||
| "sylius/sylius-rector": "^2.0", | ||
| "sylius/test-application": "^2.0", |
Member
There was a problem hiding this comment.
Suggested change
| "sylius/test-application": "^2.0", | |
| "sylius/test-application": "^2.0.0@alpha", |
Comment on lines
+2
to
+3
|
|
||
| BUNDLES_TO_ENABLE="" |
Member
There was a problem hiding this comment.
Suggested change
| BUNDLES_TO_ENABLE="" |
| @@ -0,0 +1,6 @@ | |||
| DATABASE_URL=mysql://root:root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment%?serverVersion=5.7 | |||
Member
There was a problem hiding this comment.
Suggested change
| DATABASE_URL=mysql://root:root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment%?serverVersion=5.7 | |
| DATABASE_URL=mysql://root:root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment% |
| @@ -0,0 +1,3 @@ | |||
| DATABASE_URL=mysql://root:root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment%?serverVersion=5.7 | |||
Member
There was a problem hiding this comment.
Suggested change
| DATABASE_URL=mysql://root:root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment%?serverVersion=5.7 | |
| DATABASE_URL=mysql://root:root@127.0.0.1/acme_sylius_example_plugin_%kernel.environment% |
Member
There was a problem hiding this comment.
I wonder if we shouldn't add here the initial configuration for doctrine mapping to customize entities
GSadee
approved these changes
Jul 2, 2025
GSadee
merged commit 71e3f1e
into
Sylius:feature/add_test_application
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.