[Docs] External php files for resources' configuration #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
docs/external-php-files
branch
from
0f5b9af to
6b3b4db
Compare
stlgaits
requested changes
Jan 9, 2026
Comment on lines
+59
to
+60
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Member
Author
There was a problem hiding this comment.
It may be too much, don't you think?
Comment on lines
+127
to
+128
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+189
to
+190
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+252
to
+253
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+317
to
+318
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+813
to
+814
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+896
to
+897
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+997
to
+998
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+1066
to
+1067
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Comment on lines
+241
to
+242
| ```php | ||
| use App\Entity\Book; |
Contributor
There was a problem hiding this comment.
Suggested change
| ```php | |
| use App\Entity\Book; | |
| ```php | |
| <?php | |
| declare(strict_types=1); | |
| use App\Entity\Book; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should wait for Sylius resource 1.14 stable release.