Skip to content

[Field] Add a TwigAction #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
loic425 wants to merge 1 commit into
base: 1.14
Choose a base branch
from
Draft

[Field] Add a TwigAction #376

loic425 wants to merge 1 commit into from

Conversation

@loic425
Copy link
Member

@loic425 loic425 commented May 7, 2025 •
edited
Loading

Before

final class SubscriptionGrid extends AbstractGrid 
{
    public function buildGrid(GridBuilderInterface $gridBuilder): void
    {
        $gridBuilder
            ->addActionGroup(
                ItemActionGroup::create(
                    Action::create('show', 'custom_show')
                        ->setOptions(['template' => 'grid/action/show.html.twig'])
                    ,
                )
            )
        ;
    }
}

@loic425 loic425 marked this pull request as draft May 7, 2025 09:55
@loic425 loic425 mentioned this pull request May 20, 2025
Merged
GSadee added a commit that referenced this pull request May 23, 2025
@GSadee
Allow to define a template in action definition (#377)
d9137ca 
Replace #376 

```php
final class SubscriptionGrid extends AbstractGrid 
{
    public function buildGrid(GridBuilderInterface $gridBuilder): void
    {
        $gridBuilder
            ->addActionGroup(
                ItemActionGroup::create(
                    Action::create('show', 'custom_show')
                        ->setTemplate('grid/action/show.html.twig')
                    ,
                )
            )
        ;
    }
}           
``` 

⚠️ We cannot use this feature in the test application for now, cause the
TwigGridRenderer from Resource bundle needs to use this template getter
first.

In the package, there are two ways of defining the template.
1/ On Field => within options property
2/ On Filter => directly within template property

Indeed the grid could be used in non-Twig/non-HTML context. 
Definining the template in the options could be more detached to "HTML",
but I think it's simpler for the DX to define this within a simple
setTemplate. For now we use grids within HTML in 100% of the case, and
even I already have some PoC to define console operations with grids,
this is not bad to keep that getter/setter unused there.
@loic425 loic425 force-pushed the allow-to-define-template-in-action-options branch from c86b1f2 to 5d9627c Compare August 27, 2025 08:30
@loic425 loic425 changed the title Allow to define a template in action options TwigAction Aug 27, 2025
@loic425 loic425 changed the title TwigAction [Field] Add a TwigAction Aug 27, 2025
@loic425 loic425 force-pushed the allow-to-define-template-in-action-options branch from 5d9627c to eefd674 Compare August 27, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@loic425