Fix power draw metrics on Intel Battlemage (Xe) #393
Merged
+37
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Battlemage seems to use
power2_critfor the max power values, while Alchemist usespower1_max.Previously we were only checking
power1_maxandpower2_max, but this PR implements searching ofpower*_max,power*_crit, andpower*_rated_maxfor the max power values to try and ensure that we find it.i915 also skips checking the
power2_*values since they don't exist there, while xe checks bothpower1_*andpower2_*.I've also done a slight cleanup in the surrounding areas.
This works fine on my A770, and @AbelKel has tested this branch on his B570 in issue #347.
Thanks,
Steve