Skip to content

test: fix issue where test eval fails due to incomplete eval #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

test: fix issue where test eval fails due to incomplete eval #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/test_buffered_evaluation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,11 @@ end

for turbo in (false, true), i in 1:100
# Generate a random tree with varying size (1-10 nodes)
n_nodes = rand(1:10)
tree = gen_random_tree_fixed_size(n_nodes, operators, size(X, 1), Float64, Node)
rng = Random.MersenneTwister(i)
n_nodes = rand(rng, 1:10)
tree = gen_random_tree_fixed_size(
n_nodes, operators, size(X, 1), Float64, Node, rng
)

# Regular evaluation
eval_options_no_buffer = EvalOptions(; turbo)
Expand All @@ -142,12 +145,12 @@ end

# Buffer evaluation
buffer = Array{Float64}(undef, 2n_nodes, size(X, 2))
buffer_ref = Ref(rand(1:10)) # Random starting index (will be reset)
buffer_ref = Ref(rand(rng, 1:10)) # Random starting index (will be reset)
eval_options = EvalOptions(; turbo, buffer=ArrayBuffer(buffer, buffer_ref))
result2, ok2 = eval_tree_array(tree, X, operators; eval_options)

# Results should be identical
@test isapprox(result1, result2; atol=1e-10)
@test isapprox(result1, result2; atol=1e-10) || (!ok1 && !ok2)
@test ok1 == ok2
end
end
Loading