feat: SymbolicUtils v4 compatibility (release-v1 backport)#160
Closed
MilesCranmerBot wants to merge 3 commits intoSymbolicML:release-v1from
Closed
feat: SymbolicUtils v4 compatibility (release-v1 backport)#160MilesCranmerBot wants to merge 3 commits intoSymbolicML:release-v1from
MilesCranmerBot wants to merge 3 commits intoSymbolicML:release-v1from
Conversation
Update SymbolicUtils extension to support only v4+, removing backward compatibility code for older versions. Key v4 API changes handled: - Use BasicSymbolic instead of Symbolic - Use TreeReal instead of LiteralReal - Use nameof() instead of .name field access - Sym constructor requires type= keyword argument - Handle wrapped constants via isconst/unwrap_const - Type parameter is SymVariant, not Number Breaking: index_functions=true is not supported (was already documented as "CURRENTLY UNAVAILABLE"). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use SymReal instead of TreeReal for compatibility with simplification rules - Update tests to use BasicSymbolic instead of deprecated Symbolic type - Update tests to use only supported operators (custom operators not supported in v4) - Add clear error messages when unsupported operators are used - Fix multiply_powers to handle wrapped Const integers in v4 - Update test assertions to handle v4's automatic expression simplification Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of DynamicExpressions SymbolicUtils v4 compatibility to the new release-v1 branch.\n\nIncludes:\n- SymbolicUtils compat bumped to 4\n- Updated SymbolicUtils extension for v4 API\n- Test updates; roundtrip test relaxed to avoid failing on commutative reordering while still checking semantics.\n\nLocal (fresh depot) on Julia 1.10.5 passes.