feat: composer prefer-stable, doctrine/orm 3, doctrine/doctrine-bundle 3#353
feat: composer prefer-stable, doctrine/orm 3, doctrine/doctrine-bundle 3#353bocharsky-bw merged 13 commits intoSymfonyCasts:mainfrom
Conversation
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
bocharsky-bw
left a comment
bocharsky-bw
left a comment
There was a problem hiding this comment.
Thank you for bumping it up. Could you check the failed tests, please? Looks related to the changes
|
Yes, changes are related. The config need to be adjusted for v2 vs v3. |
|
Thanks! It would be easier :) But if we know what exactly package causes it - we can revert that specific package and merge, then it will be easier to work on fixing tests for that specific package in another PR... And since you will have a merge at that time - the CI should be auto-allowed for you I think |
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3
Chris53897
changed the title
|
@bocharsky-bw ready to review. Could you pleae approve ci. |
composer.json
Outdated
| "symfony/phpunit-bridge": "^5.4 | ^6.0 | ^7.0 | ^8.0", | ||
| "doctrine/doctrine-bundle": "^2.8", | ||
| "doctrine/annotations": "^1.0", | ||
| "doctrine/doctrine-bundle": "^2.18 | ^3.0", |
There was a problem hiding this comment.
Any strong reasons to bump it to 2.18? That version requires Sf 6.4 while we're still excplicitly support 5.4 in composer.json.
There was a problem hiding this comment.
Seems Sf 5.4 support was dropped since 2.14
There was a problem hiding this comment.
It was not my intention to drop support for Symfony 5.
Just bump it to make sure that the config report_fields_where_declared is available.
I changed it now to 2.13
Maybe i need to adjust the config.
bocharsky-bw
left a comment
bocharsky-bw
left a comment
There was a problem hiding this comment.
By allowing v2.13 I think we should be good with legacy support.
Thank you!
3 participants
dev allow doctrine/orm 3, doctrine/annotations 2 and doctrine/doctrine-bundle 3