Convert Attachment Object

[GeneCodeSavvy]

This PR closes #244

I have not pushed the tests. They will fail due to #359
I will push the tests, once the mentioned PR is merged, fixing the backport issue

[jakebeal]

This is looking good to me; holding off on formally approving until #359 is resolved and the tests are pushed.

[Gonza10V]

Hi This looks good to me too, @jakebeal please merge when you aprrove it. Now #359 is merged so this should follow.

[jakebeal]

#359 may be merged, but this cannot be merged until it has tests added. @GeneCodeSavvy , can you please push the tests?

[GeneCodeSavvy]

tests are failing due to unrelated errors

FAILED test/test_calculate_sequences.py::TestCalculateSequences::test_calculate_sequences - urllib.error.HTTPError: HTTP Error 503: Service Unavailable
FAILED test/test_calculate_sequences.py::TestCalculateSequences::test_circular_calculation - urllib.error.HTTPError: HTTP Error 503: Service Unavailable
= 2 failed, 78 passed, 1 skipped, 1 xfailed, 1001 warnings in 82.88s (0:01:22) =

[jakebeal]

Re-running the failing tests gets past the rate-limits on the external services.
I've filed #368 for preventing these types of rate-limiting failures.

[jakebeal]

I see test files, but not yet a test that actually makes use of them.

[GeneCodeSavvy]

I see test files, but not yet a test that actually makes use of them.

yep, i was waiting for some clarity about the tests. I have added the tests now

[GeneCodeSavvy]

@jakebeal the test are passing now