-
Notifications
You must be signed in to change notification settings - Fork 27
fix some issues preventing the docker container from starting #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeterHindes
wants to merge
11
commits into
master
Choose a base branch
from
fix-docker-container
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6eed01a
fix some issues preventing the docker container from starting
PeterHindes b068ad5
Update Dockerfile
PeterHindes 7adf2e4
Apply suggestion from @Copilot
PeterHindes 7cbdc73
Update Dockerfile
PeterHindes 2a67205
Apply suggestion from @Copilot
PeterHindes 2fdb18d
Update saveconfig.sh
PeterHindes 77c0f57
Update Dockerfile
PeterHindes e45a0e1
Merge branch 'master' into fix-docker-container
cjmyers dabe66a
simplify changes
PeterHindes 36c8574
Merge branch 'master' into fix-docker-container
PeterHindes c9b762c
Merge branch 'master' into fix-docker-container
cjmyers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/bin/bash | ||
PeterHindes marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| set -o errexit | ||
|
|
||
| # Save git revision to config before removing .git folder | ||
| echo "Saving git revision to configuration..." | ||
| node gitrevupdate.js | ||
|
|
||
| echo "Git revision saved successfully!" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| const config = require('./lib/config') | ||
| const gitRev = require('./lib/gitRevision') | ||
|
|
||
| console.log('Updating git revision in configuration...') | ||
|
|
||
| // Get the current git revision | ||
| const revision = gitRev() | ||
|
|
||
| if (revision) { | ||
| // Set the revision in the config | ||
| config.set('revision', revision) | ||
| console.log(`Git revision updated to: ${revision}`) | ||
| } else { | ||
| console.error('Failed to get git revision') | ||
| process.exit(1) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
|
|
||
| var fs = require('fs') | ||
| var extend = require('xtend') | ||
| var deepmerge = require('deepmerge') | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,9 @@ function updateQuery (sparql, graphUri, accept) { | |
| function updateQueryJson (sparql, graphUri) { | ||
| // const timer = Timer('sparql query') | ||
|
|
||
| return updateQuery(sparql, graphUri, 'application/sparql-results+json').then(parseResult) | ||
| return updateQuery(sparql, graphUri, 'application/sparql-results+json') | ||
| .then(parseResult) | ||
| .catch(handleError) | ||
|
|
||
| function parseResult (res) { | ||
| // timer() | ||
|
|
@@ -71,6 +73,12 @@ function updateQueryJson (sparql, graphUri) { | |
|
|
||
| return Promise.resolve(sparqlResultsToArray(results)) | ||
| } | ||
|
|
||
| function handleError (error) { | ||
| console.error('SPARQL update query failed') | ||
| console.error(error.stack) | ||
| return Promise.reject(error) | ||
| } | ||
| } | ||
|
|
||
| function query (sparql, graphUri, accept, explorer = false) { | ||
|
|
@@ -200,6 +208,10 @@ function deleteStaggered (sparql, graphUri) { | |
| } else { | ||
| return performQuery() | ||
| } | ||
| }).catch((error) => { | ||
|
||
| console.error('Delete operation failed') | ||
| console.error(error.stack) | ||
| return Promise.reject(error) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.