Skip to content

Fix variable name typo in similarity_distance function#26

Merged
YoanSallami merged 1 commit intoSynaLinks:mainfrom
IGWPark:fix/omega-similarity-distance-bug
Oct 16, 2025
Merged

Fix variable name typo in similarity_distance function#26
YoanSallami merged 1 commit intoSynaLinks:mainfrom
IGWPark:fix/omega-similarity-distance-bug

Conversation

@IGWPark
Copy link
Contributor

@IGWPark IGWPark commented Oct 15, 2025

First off, thanks for building and sharing Synalinks! :)


Fixes incorrect variable assignment in similarity_distance function that causes all candidate distances to evaluate to ~0, breaking OMEGA's DNS mechanism.

Variable name typo at line 142:

Before:

embeddings1 = np.mean(embeddings1, axis=0) # Line 141
embeddings1 = np.mean(embeddings2, axis=0) # Line 142

After:

embeddings1 = np.mean(embeddings1, axis=0) # Line 141
embeddings2 = np.mean(embeddings2, axis=0) # Line 142

One-character fix to assign to the correct variable!

@YoanSallami
Copy link
Contributor

Thanks, I didn't catch it!

@YoanSallami YoanSallami merged commit 23b44ab into SynaLinks:main Oct 16, 2025
4 checks passed
@YoanSallami
Copy link
Contributor

Don't hesitate to star the project, that helps a lot :) thank you again !

RamXX pushed a commit to RamXX/synalinks that referenced this pull request Jan 23, 2026
…tance-bug

Fix variable name typo in similarity_distance function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants