Skip to content

946147: Update Stock Market Use Case Sample Based on UX Review. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmfarook7 merged 1 commit into from
Mar 11, 2025
Merged

946147: Update Stock Market Use Case Sample Based on UX Review. #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Stock-Market-Application/src/components/MyPortfolio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,7 @@ export default function MyPortfolio(props: { changeMarquee: Function, myStockDm:
{
title: 'Analysis',
buttonOption: {
iconCss: 'analysis e-icons',
cssClass: 'e-primary',
iconCss: 'analysis e-icons'
},
},
]}
Expand Down
23 changes: 21 additions & 2 deletions Stock-Market-Application/src/components/Overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,24 @@ export default function Overview(props: { changeMarquee: Function, myStockDm: Da
iconEle!.classList.add('e-chevron-down-double');
}
}
if (args.column!.field === 'High') {
let iconEle = args.cell!.querySelector('.e-icons');
iconEle!.classList.add('e-arrow-up');
let valueEle = args.cell!.querySelector('.high');
if (valueEle) {
let value = parseFloat(valueEle.innerHTML);
valueEle.innerHTML = Number.isInteger(value) ? value.toString() : value.toFixed(2);
}
}
if (args.column!.field === 'Low') {
let iconEle = args.cell!.querySelector('.e-icons');
iconEle!.classList.add('e-arrow-down');
let valueEle = args.cell!.querySelector('.low');
if (valueEle) {
let value = parseFloat(valueEle.innerHTML);
valueEle.innerHTML = Number.isInteger(value) ? value.toString() : value.toFixed(2);
}
}
if (
args.column!.field === 'Last' ||
args.column!.field === 'ChangeInValue' ||
Expand Down Expand Up @@ -303,12 +321,14 @@ export default function Overview(props: { changeMarquee: Function, myStockDm: Da
<ColumnDirective
field="High"
format="N2"
template="<span class='high'> ${High} </span ><span class='e-icons'></span>"
textAlign="Center"
width="80"
></ColumnDirective>
<ColumnDirective
field="Low"
format="N2"
template="<span class='low'> ${Low} </span ><span class='e-icons'></span>"
textAlign="Center"
width="80"
></ColumnDirective>
Expand All @@ -330,8 +350,7 @@ export default function Overview(props: { changeMarquee: Function, myStockDm: Da
{
title: 'Analysis',
buttonOption: {
iconCss: 'analysis e-icons',
cssClass: 'e-primary',
iconCss: 'analysis e-icons'
},
},
]}
Expand Down
5 changes: 3 additions & 2 deletions Stock-Market-Application/src/components/SmartStockPicks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,14 @@ export default function SmartStockPicks(props: { myStockDm: DataManager }) {
<ColumnDirective
field="High"
format="N2"
template="<span class='high'> ${High} </span ><span class='e-icons'></span>"
textAlign="Right"
width="70"
></ColumnDirective>
<ColumnDirective
field="Low"
format="N2"
template="</span><span class='low'> ${Low} </span ><span class='e-icons'>"
textAlign="Right"
width="70"
></ColumnDirective>
Expand All @@ -298,8 +300,7 @@ export default function SmartStockPicks(props: { myStockDm: DataManager }) {
{
title: 'Analysis',
buttonOption: {
iconCss: 'analysis e-icons',
cssClass: 'e-primary',
iconCss: 'analysis e-icons'
},
},
]}
Expand Down
23 changes: 19 additions & 4 deletions Stock-Market-Application/src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,16 +254,23 @@ body {

.e-grid td.e-rowcell.e-pos:not(.e-editedbatchcell):not(.e-updatedtd),
.e-grid.e-gridhover .e-row:not(.e-disable-gridhover):not(.e-editedrow):not(.e-detailrow):hover .e-rowcell.e-pos:not(.e-cellselectionbackground):not(.e-active):not(.e-updatedtd):not(.e-indentcell),
.e-grid td.e-rowcell.e-pos .e-icons {
.e-grid td.e-rowcell.e-pos .e-icons,
.e-grid td.e-rowcell .e-icons.e-arrow-up {
color: #00a653;
}

.e-grid td.e-rowcell.e-neg:not(.e-editedbatchcell):not(.e-updatedtd),
.e-grid.e-gridhover .e-row:not(.e-disable-gridhover):not(.e-editedrow):not(.e-detailrow):hover .e-rowcell.e-neg:not(.e-cellselectionbackground):not(.e-active):not(.e-updatedtd):not(.e-indentcell),
.e-grid td.e-rowcell.e-neg .e-icons {
.e-grid td.e-rowcell.e-neg .e-icons,
.e-grid td.e-rowcell .e-icons.e-arrow-down {
color: #ff3740;
}

.e-grid td.e-rowcell .e-icons.e-arrow-up,
.e-grid td.e-rowcell .e-icons.e-arrow-down {
vertical-align: middle;
}

.e-grid .e-gridheader .e-sortfilter .e-headercelldiv {
padding: 0 20px 0 8px;
}
Expand Down Expand Up @@ -353,10 +360,17 @@ text#stockchartdefault_ChartTitle {

.e-card .e-card-content {
color: #333;
padding: 0 16px 16px 16px;
max-height: 60px;
}

.row .e-card .e-card-header {
border-bottom-color: rgba(0, 0, 0, 0.15);
}

.row .e-card .e-card-actions {
border-top-color: rgba(0, 0, 0, 0.15);
}

.e-card .e-card-actions {
padding: 8px 16px 16px;
}
Expand Down Expand Up @@ -414,6 +428,7 @@ text#stockchartdefault_ChartTitle {
justify-content: center;
padding: 1rem;
margin-top: 15px;
gap: 20px;
}

.kb-carousel .e-carousel-items .e-carousel-item .product-container .heading {
Expand Down Expand Up @@ -499,7 +514,7 @@ text#stockchartdefault_ChartTitle {

@media screen and (min-width: 900px) {
.e-card-content {
min-height: 110px;
min-height: 130px;
max-height: 120px;
}
}
Expand Down