fixed mongodb download url. upped embedmongo 1.48.2->2.1.1.#6
Open
agoston wants to merge 4 commits intoSyncleus:masterfrom
Open
fixed mongodb download url. upped embedmongo 1.48.2->2.1.1.#6agoston wants to merge 4 commits intoSyncleus:masterfrom
agoston wants to merge 4 commits intoSyncleus:masterfrom
Conversation
… for mongo 3.6.6. Yay!
freemo
reviewed
Sep 29, 2018
pom.xml
Outdated
| <groupId>com.syncleus.maven.plugins</groupId> | ||
| <artifactId>mongodb-maven-plugin</artifactId> | ||
| <version>1.2.0-SNAPSHOT</version> | ||
| <groupId>com.github.agoston</groupId> |
Member
There was a problem hiding this comment.
These changes should not have been applied. If you fix it back to the original I can commit it (even if you dont ill fix it on my end when i get a chance in a day or so).
Author
There was a problem hiding this comment.
Correct, I did not expect you to pick this up so swiftly, so I started using my fork, that is what you see here.
I'll roll back these changes now.
This reverts commit 9f0cfd1.
Author
|
Hey, do you have any idea when this will get merged? I kinda need it, since mongo 3.6 is running on production by us already, so we're testing code against an old version. |
Member
|
I will do it today, sorry for delay wqas traveling and got stranded along
the way for the better part of a week.
…On Wed, Oct 10, 2018 at 3:51 PM Agoston Horvath ***@***.***> wrote:
Hey, do you have any idea when this will get merged? I kinda need it,
since mongo 3.6 is running on production by us already, so we're testing
code against an old version.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC5JAoWQfkxynDn4u4IslPYK4KQk0rWcks5ujftkgaJpZM4W-kro>
.
|
|
@freemo will this be merged? I need this fix for a project asap. |
Member
|
I can get it merged in for ya if your using it. But this project has been
idle a long time, im not even sure it still works. I think there are also
better options out there by now. You sure you need it, if so I can try to
get a merge in for ya.
…On Sat, 7 Dec 2024 at 10:17, William ***@***.***> wrote:
@freemo <https://github.com/freemo> will this be merged? I need this fix
for a project asap.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXESASPZNXDYLEBBSSJ56L2EMGPZAVCNFSM6AAAAABTGJMBZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGIYDANJQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@freemo Yeah ur probably right, then there is no need for you to merge it, i'm pretty new to integration testing, can you recommend any good alternative plugins? |
Member
|
Honestly i havent had to run mongodb tests in a while, ive moved on to
other graphDB mostly.
I think this project may have forked us and appears a bit more up to date:
https://github.com/joelittlejohn/embedmongo-maven-plugin
Or you can roll your own with an in-memory mongodb implementation as part
of a proper unit/integration test:
https://www.mongodb.com/docs/manual/core/inmemory/
…On Sat, 7 Dec 2024 at 10:32, William ***@***.***> wrote:
@freemo <https://github.com/freemo> Yeah ur probably right, then there is
no need for you to merge it, i'm pretty new to integration testing, can you
recommend any good alternative plugins?
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXESAU7EMA6BTNEBRLIARL2EMIJ5AVCNFSM6AAAAABTGJMBZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGIYTAMBWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin now works for mongodb 3.6.6. Fixed #5.