Added support for memento player#716
Merged
Et0h merged 2 commits intoSyncplay:masterfrom Jun 17, 2025
Merged
Conversation
Contributor
|
Nice work. I'll review this more when I have time - but from a quick look I don't see any issues. I'll check to see if there is a default Windows path for Memento to add to the list. |
Signed-off-by: Eyal Mazuz <mazuzeyal@protonmail.com>
Contributor
|
Okay, I just checked and the Windows path is: It seems to work fine on Windows so far, but I'll give it a bit more testing to confirm. |
Et0h
added a commit
that referenced
this pull request
Jun 17, 2025
Add Windows path for Memento (#716)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support to memento (mpv-based) player for syncplay
Solving #714