Instead of localhost, use 127.0.0.1 (Fixes #302)

[smiba]

In issue #302 on MacOS (and presumably Linux), a wrongly configured hosts file can result in localhost not resolving

MacOS will for the most part function fine without it, allowing the system to otherwise function acceptably, while syncplay fails to work using VLC.

This change is slightly questionable though, as it could be said not having a definition of localhost is a failure on the operator of the system's part.

Feel free to reject this PR in that case.

[Et0h]

Thanks for this suggested PR.

If this fixes a bug and doesn't create any new bugs then I'm happy for it to be accepted even if it is only to resolve a problem caused by the operator not properly configuring localhost. Fewer problems means less support requests, so everyone is happy.

I'm not aware of here aren't any setups which don't allow 127.0.0.1 for loopback and instead require ::1 IPv6 for loopback, but it's not something I've really researched in any detail.

[smiba]

In my testing on MacOS it did fix the issue, when localhost does not resolve to anything.

I'm not aware of here aren't any setups which don't allow 127.0.0.1 for loopback and instead require ::1 IPv6 for loopback, but it's not something I've really researched in any detail.

I guess the question might be what people are more likely to encounter, a IPv6 only loopback, or localhost failing to resolve.

I would argue that not many systems will not have a IPv4 loopback, I've certainly never come across it... So this should be pretty safe, but at the same time no guarantees 😅

[Et0h]

I guess we can always just cross that bridge if someone reports a problem with 127.0.0.1 - hard to plan for such a hypothetical without an actual real world example, so instead it makes sense to prioritise a confirmed if relatively obscure problem which has a simple fix.