Skip to content

perf(collections): replace SortedMap with an internally sorted impl#1173

Open
Sobeston wants to merge 16 commits intomainfrom
sobe/fixed-sortedmap
Open

perf(collections): replace SortedMap with an internally sorted impl#1173
Sobeston wants to merge 16 commits intomainfrom
sobe/fixed-sortedmap

Conversation

@Sobeston
Copy link
Contributor

@Sobeston Sobeston commented Jan 9, 2026

No description provided.

@Sobeston Sobeston self-assigned this Jan 9, 2026
@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Jan 9, 2026
@Sobeston Sobeston force-pushed the sobe/fixed-sortedmap branch from b352c13 to c3b8889 Compare January 15, 2026 19:28
@Sobeston Sobeston force-pushed the sobe/fixed-sortedmap branch from c3b8889 to 2345a90 Compare January 15, 2026 19:44
@dnut dnut linked an issue Jan 26, 2026 that may be closed by this pull request
@kprotty kprotty marked this pull request as ready for review January 29, 2026 00:03
@kprotty kprotty requested review from dnut, ultd and yewman as code owners January 29, 2026 00:03
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 95.49550% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ledger/database/hashmap.zig 66.66% 14 Missing ⚠️
src/utils/sorted_map.zig 95.65% 8 Missing ⚠️
src/replay/consensus/cluster_sync.zig 93.33% 4 Missing ⚠️
src/consensus/fork_choice.zig 97.80% 2 Missing ⚠️
src/ledger/Reader.zig 94.28% 2 Missing ⚠️
src/ledger/shred_inserter/working_state.zig 92.85% 2 Missing ⚠️
src/consensus/replay_tower.zig 97.14% 1 Missing ⚠️
src/ledger/meta.zig 93.33% 1 Missing ⚠️
src/ledger/shred_inserter/slot_chaining.zig 88.88% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/consensus/optimistic_vote_verifier.zig 98.24% <100.00%> (+0.04%) ⬆️
src/core/hash.zig 98.46% <100.00%> (+0.70%) ⬆️
src/ledger/ResultWriter.zig 92.89% <100.00%> (ø)
src/ledger/cleanup_service.zig 96.27% <100.00%> (ø)
src/ledger/shred.zig 90.69% <ø> (ø)
src/ledger/shred_inserter/ShredInserter.zig 84.22% <100.00%> (+0.28%) ⬆️
src/ledger/tests.zig 90.05% <100.00%> (ø)
src/replay/consensus/core.zig 94.59% <100.00%> (ø)
src/replay/service.zig 92.95% <100.00%> (ø)
src/runtime/program/vote/state.zig 97.05% <100.00%> (+0.14%) ⬆️
... and 11 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move the sorted set / map tests from collections.zig into sorted_map.zig?

@yewman yewman self-requested a review February 6, 2026 17:50
@kprotty kprotty self-assigned this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

perf: better sorted map

3 participants