feat(rpc): implement getSlot RPC method by ajw221 · Pull Request #1197 · Syndica/sig

ajw221 · 2026-02-02T16:36:00Z

Intent

Implement getSlot RPC method

Implementation

Added ForkChoiceProcessedSlot and OptimisticallyConfirmedSlot atomic trackers to src/replay/trackers.zig
Added SlotHookContext to src/rpc/methods.zig which reads slot state from SlotTracker based on commitment level
Updated SlotTracker.root to be atomic for thread-safe access from RPC
Wired latest_processed_slot updates in consensus mode (during vote handling) and bypass mode (from SlotTree.tip())
Wired latest_confirmed_slot updates in vote listener when optimistic confirmation threshold is reached

Ramifications

ForkChoiceProcessedSlot uses store() rather than fetchMax() because the processed slot can decrease when fork choice switches to a different fork
In bypass-consensus mode, processed slot is set to the highest fork tip, which differs from Agave's semantics where it only updates when voting

Tests

Updated existing unit tests to include the new slot tracker dependencies
Added assertions verifying slot trackers remain at initial state after expected failures

src/rpc/methods.zig

codecov · 2026-02-04T16:00:42Z

Codecov Report

❌ Patch coverage is 96.22642% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/replay/trackers.zig	92.85%	2 Missing ⚠️
src/consensus/vote_listener.zig	85.71%	1 Missing ⚠️
src/replay/service.zig	88.88%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/consensus/replay_tower.zig	`96.16% <100.00%> (+<0.01%)`	⬆️
src/replay/consensus/cluster_sync.zig	`91.56% <100.00%> (+<0.01%)`	⬆️
src/replay/consensus/core.zig	`94.98% <100.00%> (+<0.01%)`	⬆️
src/replay/consensus/process_result.zig	`93.37% <100.00%> (+0.02%)`	⬆️
src/rpc/methods.zig	`79.66% <ø> (ø)`
src/consensus/vote_listener.zig	`93.39% <85.71%> (-0.09%)`	⬇️
src/replay/service.zig	`93.66% <88.88%> (+0.03%)`	⬆️
src/replay/trackers.zig	`98.89% <92.85%> (-0.71%)`	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dnut

my main overall thought is to move all the slot integers to be owned by the slot tracker which would solve several of my comments including the stack pointer uafs

src/replay/consensus/process_result.zig

src/replay/service.zig

src/consensus/vote_listener.zig

src/replay/consensus/core.zig

src/rpc/methods.zig

src/replay/trackers.zig

src/cmd.zig

src/replay/trackers.zig

src/rpc/methods.zig

src/replay/consensus/core.zig

src/replay/trackers.zig

- Add SlotTree.tip() to get highest slot among fork leaves (bypass mode) - Update latest_processed_slot inside vote handling to match Agave behavior - Update latest_processed_slot in bypassConsensus() from SlotTree.tip() - Change ForkChoiceProcessedSlot to use store() since slot can decrease Note: Bypass mode uses highest fork tip, while consensus mode matches Agave's semantics where processed slot only updates when voting.

…o avoid uafs

…e guide

Condense nested if statements into single-line conditional return.

…AndHandleNewRoot test

…acker

ajw221 self-assigned this Feb 2, 2026

github-project-automation bot added this to Sig Feb 2, 2026

github-project-automation bot moved this to 🏗 In progress in Sig Feb 2, 2026

ajw221 changed the base branch from main to harnew/epoch-state-tracking February 2, 2026 16:36

ajw221 force-pushed the adamw/implement-getSlot-in-rpc branch from 5c910f3 to a29f437 Compare February 2, 2026 23:55

prestonsn reviewed Feb 3, 2026

View reviewed changes

src/rpc/methods.zig Outdated Show resolved Hide resolved

ajw221 changed the base branch from harnew/epoch-state-tracking to main February 3, 2026 14:38

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch 2 times, most recently from 88d9154 to c5b6298 Compare February 4, 2026 15:13

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch from c5b6298 to ccfde8d Compare February 4, 2026 16:16

prestonsn self-assigned this Feb 4, 2026

prestonsn changed the title ~~feat(rpc): implement getSlot~~ feat(rpc): implement getSlot RPC method Feb 4, 2026

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch 2 times, most recently from 40fae04 to 72d8727 Compare February 9, 2026 17:58

dnut marked this pull request as ready for review February 9, 2026 18:54

dnut requested changes Feb 10, 2026

View reviewed changes

github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Feb 10, 2026

dnut requested a review from InKryption February 10, 2026 00:36

prestonsn requested review from ultd and yewman as code owners February 10, 2026 19:18

Sobeston reviewed Feb 10, 2026

View reviewed changes

src/rpc/methods.zig Outdated Show resolved Hide resolved

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch 2 times, most recently from e7172e5 to 0568f9e Compare February 12, 2026 22:08

dnut reviewed Feb 13, 2026

View reviewed changes

src/replay/consensus/core.zig Outdated Show resolved Hide resolved

src/replay/trackers.zig Outdated Show resolved Hide resolved

dnut approved these changes Feb 13, 2026

View reviewed changes

ajw221 and others added 4 commits February 13, 2026 22:24

feat(rpc): WIP implement getSlot

63614ba

fix(tests): add processed and confirmed slot trackers to unit tests

a28912e

fix(replay): move processed and confirmed counters into SlotTracker t…

0aa305a

…o avoid uafs

prestonsn added 6 commits February 13, 2026 22:24

fix(core): remove redundant asert from edge cases unit tests

82b8f37

fix(methods): inline getSlotImpl into getSlot RPC callback

e82c43f

fix(trackers, methods): remove use of @this() in accordance with styl…

dcaa0aa

…e guide

refactor(rpc): simplify minContextSlot check in getSlot

44aad6d

Condense nested if statements into single-line conditional return.

fix(tests): wrap SlotTracker in RwMux for thread-safe access in check…

ab567fd

…AndHandleNewRoot test

fix(consensus): TowerConsensus does not need mutable access to SlotTr…

8279fe0

…acker

ajw221 force-pushed the adamw/implement-getSlot-in-rpc branch from 7d84370 to 8279fe0 Compare February 14, 2026 03:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rpc): implement getSlot RPC method#1197

feat(rpc): implement getSlot RPC method#1197
ajw221 wants to merge 10 commits intomainfrom
adamw/implement-getSlot-in-rpc

ajw221 commented Feb 2, 2026 •

edited by prestonsn

Loading

Uh oh!

Uh oh!

codecov bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

dnut left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ajw221 commented Feb 2, 2026 • edited by prestonsn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Intent

Implementation

Ramifications

Tests

Uh oh!

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dnut left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ajw221 commented Feb 2, 2026 •

edited by prestonsn

Loading

codecov bot commented Feb 4, 2026 •

edited

Loading