Skip to content

fix(rocksdb): nextValue copy paste bug#1210

Open
ajw221 wants to merge 2 commits intomainfrom
adamw/fix-rocksdb-nextvalue-bug
Open

fix(rocksdb): nextValue copy paste bug#1210
ajw221 wants to merge 2 commits intomainfrom
adamw/fix-rocksdb-nextvalue-bug

Conversation

@ajw221
Copy link
Contributor

@ajw221 ajw221 commented Feb 5, 2026

Intent

  • Fix RocksDB.nextValue copy paste bug matching RocksDB.nextKey

Implementation

  • Updated RocksDB.nextValue to use value_serializerinstead ofkey_serializer`

Ramifications

  • This bug is currently affecting several functions in Reader.zig, which rely on nextValue for processing data

Test

  • Added a sanity check unit test around this fix to ensure it doesn't regress

@ajw221 ajw221 self-assigned this Feb 5, 2026
@ajw221 ajw221 requested review from dnut, ultd and yewman as code owners February 5, 2026 16:55
@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Feb 5, 2026
@ajw221 ajw221 force-pushed the adamw/fix-rocksdb-nextvalue-bug branch from d43f707 to 7c3002c Compare February 5, 2026 17:01
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/ledger/database/interface.zig 99.73% <100.00%> (+0.01%) ⬆️
src/ledger/database/rocksdb.zig 99.34% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sobeston
Sobeston previously approved these changes Feb 6, 2026
dnut
dnut previously approved these changes Feb 10, 2026
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Feb 10, 2026
@dnut dnut added this pull request to the merge queue Feb 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2026
@Sobeston Sobeston added this pull request to the merge queue Feb 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2026
@yewman yewman added this pull request to the merge queue Feb 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 11, 2026
@yewman yewman added this pull request to the merge queue Feb 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@Sobeston
Copy link
Contributor

needs a rebase

@dnut dnut added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@ajw221 ajw221 force-pushed the adamw/fix-rocksdb-nextvalue-bug branch from 7c3002c to b8fec20 Compare February 13, 2026 21:03
@ajw221 ajw221 dismissed stale reviews from dnut and Sobeston via aeeb886 February 13, 2026 21:19
@ajw221 ajw221 force-pushed the adamw/fix-rocksdb-nextvalue-bug branch from b8fec20 to aeeb886 Compare February 13, 2026 21:19
@ajw221 ajw221 force-pushed the adamw/fix-rocksdb-nextvalue-bug branch from aeeb886 to 665e86e Compare February 13, 2026 21:20
@ajw221 ajw221 requested a review from dnut February 13, 2026 21:47
@ajw221 ajw221 requested a review from Sobeston February 13, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

3 participants