Skip to content

Audit fixes #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ibremseth wants to merge 2 commits into
base: uups
Choose a base branch
from
Open

Audit fixes #936

ibremseth wants to merge 2 commits into from

Conversation

@ibremseth
Copy link
Collaborator

@ibremseth ibremseth commented Jan 26, 2026

What does this PR do?

Summary:
Fixes some findings from the audit

  • Finding 2: Documentation and Implementation Mismatch in _getSlotValueFromProof Function
  • Finding 6: Misleading Parameter Name ethBlockHeader in confirmEpochDataHash Function
  • Finding 7: Missing Event Emission in setFactory Function

And then updates some audit documentation around Finding 4

How can this PR be tested?

forge test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ibremseth