fix(ci): update test.yml workflow to match actual project structure#70
fix(ci): update test.yml workflow to match actual project structure#70oalanicolas merged 1 commit intomainfrom
Conversation
- Remove references to non-existent packages (memory, security, performance, telemetry) - Remove build:packages script reference (doesn't exist) - Update build-test to test actual workspace and installer packages - Update integration-test to test CLI and core modules - Update performance-test with practical performance checks Co-Authored-By: Claude (claude-opus-4-5-alan) <noreply@anthropic.com>
WalkthroughThe test workflow has been restructured to eliminate matrix-based per-package testing, instead focusing on validating the core workspace package, CLI entry points, and performance metrics with simplified file existence checks and conditional skipping of optional components. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/test.yml:
- Around line 192-196: The find commands for AGENT_COUNT and TASK_COUNT can fail
if the directories don't exist; update the script around AGENT_COUNT and
TASK_COUNT to check for directory existence (e.g., test -d
".aios-core/development/agents" and ".aios-core/development/tasks") before
running find, and set the counts to 0 when the directories are absent so the
echo lines still run reliably; modify the logic where AGENT_COUNT and TASK_COUNT
are computed to use these existence guards.
🧹 Nitpick comments (3)
.github/workflows/test.yml (3)
94-104: Consider validating installer package.json content for consistency.The workspace package validation (lines 85-88) actually parses and validates
package.json, but the installer package test only checks for file existence without validating its content. For consistency, consider adding similar validation:if [ -f "package.json" ]; then echo "✅ Installer package.json exists" + node -e " + const pkg = require('./package.json'); + console.log('✅ Installer package validation passed:', pkg.name); + " fiAlso, if the directory exists but
package.jsonis missing, the step silently succeeds. If this is intentional for optional components, it's fine, but you may want to add a warning message for that case.
122-149: CLI integration test validates existence but not functionality.The test confirms the CLI entry points exist but doesn't verify they are syntactically valid or can be required without errors. Consider adding a basic syntax check:
if (fs.existsSync('./bin/aios.js')) { console.log('✅ aios.js exists'); + // Basic syntax validation + require('./bin/aios.js'); + console.log('✅ aios.js is syntactically valid'); } else {If requiring the modules has side effects that make this impractical, the current approach is acceptable.
199-207: Error suppression may hide manifest generation failures.Redirecting stderr to
/dev/null(line 200) silently ignores errors from the manifest generation script. If the script fails, you'll get a timing measurement but no indication of failure.Consider capturing the exit code:
START_TIME=$(date +%s%N) - node scripts/generate-install-manifest.js > /dev/null 2>&1 + if ! node scripts/generate-install-manifest.js > /dev/null 2>&1; then + echo "⚠️ Manifest generation script failed" + fi END_TIME=$(date +%s%N)Alternatively, if failures are acceptable for this performance check, add a comment explaining that intent.
| AGENT_COUNT=$(find .aios-core/development/agents -name "*.md" | wc -l) | ||
| echo "✅ Agent definitions: $AGENT_COUNT" | ||
|
|
||
| TASK_COUNT=$(find .aios-core/development/tasks -name "*.md" | wc -l) | ||
| echo "✅ Task definitions: $TASK_COUNT" |
There was a problem hiding this comment.
Add existence checks before find commands to prevent unexpected failures.
The find commands will fail if the directories don't exist, potentially failing the entire performance-test job. Consider adding guards:
- AGENT_COUNT=$(find .aios-core/development/agents -name "*.md" | wc -l)
- echo "✅ Agent definitions: $AGENT_COUNT"
+ if [ -d ".aios-core/development/agents" ]; then
+ AGENT_COUNT=$(find .aios-core/development/agents -name "*.md" | wc -l)
+ echo "✅ Agent definitions: $AGENT_COUNT"
+ else
+ echo "ℹ️ Agent definitions directory not found"
+ fiApply similarly to the task definitions check on line 195-196.
🤖 Prompt for AI Agents
In @.github/workflows/test.yml around lines 192 - 196, The find commands for
AGENT_COUNT and TASK_COUNT can fail if the directories don't exist; update the
script around AGENT_COUNT and TASK_COUNT to check for directory existence (e.g.,
test -d ".aios-core/development/agents" and ".aios-core/development/tasks")
before running find, and set the counts to 0 when the directories are absent so
the echo lines still run reliably; modify the logic where AGENT_COUNT and
TASK_COUNT are computed to use these existence guards.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.