framework: add standardized boolean parsing helper #6897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce mk/spksrc.bool.mk with helper functions for consistent boolean evaluation across the build system. This normalizes various boolean representations (yes/no, true/false, 1/0, y/n) into a consistent format. Helper functions: - bool(VAR): returns "true" or "false" - is_true(VAR): returns "true" if truthy, empty if falsy - is_false(VAR): returns "false" if falsy, empty if truthy Update spksrc.service.mk to use the new helpers for: - NO_SERVICE_SHORTCUT check (packages use both yes and true) - USE_DATA_SHARE_WORKER check This is an initial step toward addressing the boolean parsing inconsistency noted in issue SynoCommunity#6892.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
mk/spksrc.bool.mk- New helper withbool(),is_true(),is_false()functionsmk/spksrc.common.mk- Includes the new helpermk/spksrc.service.mk- UpdatedNO_SERVICE_SHORTCUTandUSE_DATA_SHARE_WORKERchecksAnalysis Findings
,1)patternNO_SERVICE_SHORTCUThas mixed usage (yes,true,y)Fixes #
Checklist
all-supportedcompleted successfullyType of change