tc-rust.mk: Fix Rust target detection by moving checks to runtime #6919
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust toolchain and target availability were previously evaluated using Makefile conditionals (ifeq), which are resolved at parse time and do not reflect runtime changes made by rustup commands. This caused incorrect behavior for non-standard Rust toolchains (e.g. qoriq), where the default rustup toolchain does not support the requested target (powerpc-unknown-linux-gnuspe), yet the Make logic still attempted to add it. The logic has been corrected by performing rustup toolchain and target availability checks at runtime in the shell, ensuring that targets are only added when supported by the selected Rust toolchain and avoiding invalid rustup invocations.
hgy59
added
framework
build/rust-qoriq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rust toolchain and target availability were previously evaluated using Makefile conditionals (ifeq), which are resolved at parse time and do not reflect runtime changes made by rustup commands.
This caused incorrect behavior for non-standard Rust toolchains (e.g. qoriq), where the default rustup toolchain does not support the requested target (powerpc-unknown-linux-gnuspe), yet the Make logic still attempted to add it.
The logic has been corrected by performing rustup toolchain and target availability checks at runtime in the shell, ensuring that targets are only added when supported by the selected Rust toolchain and avoiding invalid rustup invocations.
Follows-up #6877
Discovered at #6914
Checklist
all-supportedcompleted successfullyType of change