fix: 🐛 Preventing run time panics with ssr #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing all local signals and storage from ssr changed signature of `use_websocket` (removed ws signal)
Contributor
Author
|
I'm not sure why there are conflicts. Maybe we can resolve them together? |
maccesch
requested changes
Nov 6, 2025
Contributor
maccesch
left a comment
maccesch
left a comment
There was a problem hiding this comment.
Nice attention to detail
Contributor
|
The merge conflicts are very weird. Did you pull the latest main? |
Contributor
Author
|
Side node. The book does not build because of use_screen_rotation, which I already fixed in the "use_event_source" PR. |
Contributor
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all local signals and storage from ssr
changed signature of
use_websocket(removed ws signal)