Merged
Conversation
Contributor
Author
|
One question regarding Effect::watch(
move || enabled.get(),
move |enabled, _, _| {
if *enabled {
leptos::task::spawn_local({
#[cfg(not(feature = "ssr"))]
let _start = _start.clone();
async move {
_start().await;
}
});
} else {
_stop();
}
},
true,
);As far as I understand, a leptos Effect is only executed inside the reactive system on client side. Therefore we do not need to check |
Contributor
Author
|
I suggest some rework of the API of these hooks:
|
Contributor
|
Thank you!
Answered in Discord.
I'm a bit torn with this one... we have a few other hooks that use this kind of options.
Both also answered in Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.