Conversation
robertkotcher
approved these changes
Sep 23, 2021
robertkotcher
left a comment
robertkotcher
left a comment
There was a problem hiding this comment.
approving so I don't keep getting alerts.. but we probably won't be merging this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, the
CameraNormals.R/G/Bchannels in the EXR file now contains surface normals directly in camera coordinates, so users won't have to convert it themselves.This was sitting on my local system, probably needs testing before it goes out.
Added a getting started to the readme.