Skip to content

Logger#76

Merged
pazz merged 7 commits intomainfrom
logger
Apr 7, 2025
Merged

Logger#76
pazz merged 7 commits intomainfrom
logger

Conversation

@pazz
Copy link
Copy Markdown
Collaborator

@pazz pazz commented Apr 4, 2025

This allows to configure the logger and make the outputs on stderr and stdout a little less noisy unless otherwise requested (muiltiply giving -v to increase verbosity)

@pazz
Copy link
Copy Markdown
Collaborator Author

pazz commented Apr 5, 2025

It'd be good to also add an option to log to file.

@pazz pazz requested a review from Copilot April 6, 2025 14:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@pazz
Copy link
Copy Markdown
Collaborator Author

pazz commented Apr 6, 2025

vibecoding.

@pazz pazz requested a review from Copilot April 6, 2025 20:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/strategy.rs:41

  • [nitpick] Since the print! macro is commented out, the subsequent flush call may be redundant; consider removing the flush call if no output is expected.
            // print!(".");

src/semigroup.rs:197

  • [nitpick] The print! statement has been commented out, but its associated flush call remains; if no output is desired, removing the flush could improve clarity and efficiency.
                //print!(".");

src/semigroup.rs:253

  • [nitpick] Commenting out the print! macro makes the flush call on the following line potentially unnecessary; consider removing it to avoid unnecessary IO operations.
                //print!(".");

@Numero7
Copy link
Copy Markdown
Collaborator

Numero7 commented Apr 7, 2025

@pazz the linter did fail on this one, is it possible you fix it before merging? Also feel free to merge yourself any PR (as long as the CI do succeed :-) )

@pazz
Copy link
Copy Markdown
Collaborator Author

pazz commented Apr 7, 2025

silly me. I now finally installed the clippy tool locally to notice this early enough. Learning on the "job" :)

@pazz pazz merged commit 63aec4b into main Apr 7, 2025
1 check passed
@pazz pazz deleted the logger branch April 7, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants