Conversation
Collaborator
Author
|
It'd be good to also add an option to log to file. |
Collaborator
Author
|
vibecoding. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/strategy.rs:41
- [nitpick] Since the print! macro is commented out, the subsequent flush call may be redundant; consider removing the flush call if no output is expected.
// print!(".");
src/semigroup.rs:197
- [nitpick] The print! statement has been commented out, but its associated flush call remains; if no output is desired, removing the flush could improve clarity and efficiency.
//print!(".");
src/semigroup.rs:253
- [nitpick] Commenting out the print! macro makes the flush call on the following line potentially unnecessary; consider removing it to avoid unnecessary IO operations.
//print!(".");
Collaborator
|
@pazz the linter did fail on this one, is it possible you fix it before merging? Also feel free to merge yourself any PR (as long as the CI do succeed :-) ) |
Collaborator
Author
|
silly me. I now finally installed the clippy tool locally to notice this early enough. Learning on the "job" :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to configure the logger and make the outputs on stderr and stdout a little less noisy unless otherwise requested (muiltiply giving
-vto increase verbosity)