Skip to content

added logo#77

Merged
pazz merged 4 commits intomainfrom
feat_icon
Apr 8, 2025
Merged

added logo#77
pazz merged 4 commits intomainfrom
feat_icon

Conversation

@Numero7
Copy link
Copy Markdown
Collaborator

@Numero7 Numero7 commented Apr 7, 2025

No description provided.

@Numero7 Numero7 requested review from Copilot and pazz April 7, 2025 18:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@Numero7
Copy link
Copy Markdown
Collaborator Author

Numero7 commented Apr 7, 2025

@pazz that is your first proposal, what do you think?

@pazz
Copy link
Copy Markdown
Collaborator

pazz commented Apr 8, 2025

I actually quite like the second logo as well.
The logo integration in the readme here looks good:
https://github.com/Rdatatable/data.table/blob/master/README.md

@Numero7
Copy link
Copy Markdown
Collaborator Author

Numero7 commented Apr 8, 2025

@pazz are you sure the quality is good enough? Looks very pixellized

@pazz pazz merged commit a0ff008 into main Apr 8, 2025
1 check passed
@pazz pazz deleted the feat_icon branch April 8, 2025 07:57
@Numero7
Copy link
Copy Markdown
Collaborator Author

Numero7 commented Apr 8, 2025

@pazz not that great in dark mode, is there something you can do ? image

@pazz
Copy link
Copy Markdown
Collaborator

pazz commented Apr 8, 2025

@pazz not that great in dark mode, is there something you can do ? image

Oh, not so nice indeed. Well, we could just leave the white background?

sorry for the many PRs, it is a little annoying to edit the README

@Numero7
Copy link
Copy Markdown
Collaborator Author

Numero7 commented Apr 8, 2025

@pazz perfect :-) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants