AJFJFJFIEOIFOIW FFINALLYYYYYYYY MROOOWWWWW BEEEEP THANK YOU 0xC74E#52
AJFJFJFIEOIFOIW FFINALLYYYYYYYY MROOOWWWWW BEEEEP THANK YOU 0xC74E#52System-End merged 1 commit intomainfrom
Conversation
Deploying my-website with
|
| Latest commit: |
b06349d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bbe3038e.personal-website-f0d.pages.dev |
| Branch Preview URL: | https://dev.personal-website-f0d.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR primarily updates presentation and project documentation: it reformats the EndOS boot animation CSS, cleans up SVG metadata, and switches README setup commands to pnpm to better match the repo’s tooling.
Changes:
- Re-indents
EndOSBootAnimation.cssand tweaks.logo-displaystyling. - Removes Inkscape-specific export metadata from an SVG asset.
- Updates README install/start commands from npm to pnpm.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/styles/EndOSBootAnimation.css |
Large CSS reformat; introduces display: flex !important on .logo-display. |
public/images/blobfox/blobfoxnomcake.svg |
Removes editor/export metadata from the SVG header. |
README.md |
Switches install/start instructions to pnpm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .endos-boot-container { | ||
| position: fixed; | ||
| inset: 0; | ||
| background-color: #000000; | ||
| z-index: 9999; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| font-family: "Orbitron", monospace; | ||
| color: #00e5ff; | ||
| overflow: hidden; | ||
| position: fixed; | ||
| inset: 0; | ||
| background-color: #000000; | ||
| z-index: 9999; | ||
| display: flex; |
There was a problem hiding this comment.
This file was re-indented to 2 spaces, but the repository-wide EditorConfig specifies 4-space indentation for all files (see .editorconfig indent_size = 4). To avoid formatting churn (especially with the Prettier workflow) and keep style consistent with the rest of src/styles/*.css, please reformat this file to 4-space indents or adjust the repo’s formatting config (EditorConfig/Prettier) in the same PR so they agree.
| display: flex !important; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
|
|
There was a problem hiding this comment.
.logo-display is applied on the same element as boot-stage (see className={"boot-stage logo-display ..."} in the component). Setting display: flex !important here overrides the base .boot-stage { display: none; }, so the logo stage will no longer be fully removed from layout/paint when inactive. A safer approach is to keep display controlled by .boot-stage and only opt into flex when active (e.g., a more specific .boot-stage.logo-display.active { display: flex; }), without !important.
| display: flex !important; | |
| flex-direction: column; | |
| align-items: center; | |
| justify-content: center; | |
| } | |
| flex-direction: column; | |
| align-items: center; | |
| justify-content: center; | |
| } | |
| .boot-stage.logo-display.active { | |
| display: flex; | |
| } |
| 3. Install dependencies: | ||
| ```bash | ||
| npm install | ||
| pnpm install | ||
| ``` | ||
|
|
||
| ## Local Development | ||
|
|
||
| Start the development server: | ||
| ```bash | ||
| npm start | ||
| pnpm start | ||
| ``` |
There was a problem hiding this comment.
README now instructs pnpm install/pnpm start, but other parts of the same doc still list npm as a prerequisite and use npm commands for build/deploy/troubleshooting. Please update the prerequisites and the remaining commands to consistently reference pnpm (or explicitly document that npm is also supported) so new contributors don’t follow mixed instructions.
No description provided.