Skip to content

Allow server initialisation to happen outside of begin() #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow server initialisation to happen outside of begin() #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6260e4c
split server initialisation out into a separate function
webmonkey Aug 13, 2023
c2bc04c
Merge branch 'T-vK:master' into master
webmonkey Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions BleKeyboard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,20 @@ BleKeyboard::BleKeyboard(std::string deviceName, std::string deviceManufacturer,
, deviceManufacturer(std::string(deviceManufacturer).substr(0,15))
, batteryLevel(batteryLevel) {}

void BleKeyboard::init(void)
{
if(!initialised) {
BLEDevice::init(deviceName);
BLEServer* pServer = BLEDevice::createServer();
pServer->setCallbacks(this);
initialised = true;
}
}

void BleKeyboard::begin(void)
{
BLEDevice::init(deviceName);
init();
BLEServer* pServer = BLEDevice::createServer();
pServer->setCallbacks(this);

hid = new BLEHIDDevice(pServer);
inputKeyboard = hid->inputReport(KEYBOARD_ID); // <-- input REPORTID from report map
Expand Down
2 changes: 2 additions & 0 deletions BleKeyboard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ class BleKeyboard : public Print, public BLEServerCallbacks, public BLECharacter
bool connected = false;
uint32_t _delay_ms = 7;
void delay_ms(uint64_t ms);
bool initialised = false;

uint16_t vid = 0x05ac;
uint16_t pid = 0x820a;
Expand All @@ -152,6 +153,7 @@ class BleKeyboard : public Print, public BLEServerCallbacks, public BLECharacter
public:
BleKeyboard(std::string deviceName = "ESP32 Keyboard", std::string deviceManufacturer = "Espressif", uint8_t batteryLevel = 100);
void begin(void);
void init(void);
void end(void);
void sendReport(KeyReport* keys);
void sendReport(MediaKeyReport* keys);
Expand Down