Added support for dynamic fractal#135
Open
masterchief1604 wants to merge 6 commits intodevelopmentfrom
Open
Conversation
masterchief1604
force-pushed
the
dynamic_fractal
branch
from
d60e057 to
ab36d7e
Compare
flatFeather
approved these changes
Jan 16, 2025
| child: GestureDetector( | ||
| onTapDown: (details) { | ||
| setState(() { | ||
| var aspectRatio = MediaQuery.of(context).size.width / |
Contributor
There was a problem hiding this comment.
The coordinate calculations in onTapDown and onScaleUpdate are complex and could perhaps be abstracted into reusable utility functions, such as calculateOffset or adjustZoom.
| // this changes the zoom and offset | ||
|
|
||
| if (details.scale != 1.0) { | ||
| var zoomFactor = details.scale < 1.0 ? 1.01 : 0.99; |
Contributor
There was a problem hiding this comment.
There are several ‘magic’ values in the code (1.01, 0.99, 0.001, 0.5, etc.). These should be extracted into constants with descriptive names to improve readability and ease of tuning.
| child: GestureDetector( | ||
| onTapDown: (details) { | ||
| setState(() { | ||
| var aspectRatio = MediaQuery.of(context).size.width / |
Contributor
There was a problem hiding this comment.
MediaQuery.of(context) is called multiple times. Store it in a local variable to improve performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.