Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
encrypt_safeとdecrypt_safeに同一の入力検証ロジックが存在しており、重複とエラーメッセージ散逸を防ぐために共通化する必要があった。Description
encrypt_safe/decrypt_safeの検証処理を private 関数validate_safe_inputsに集約して重複を削減した。InvalidShiftのエラーメッセージ生成をinvalid_shift_errorに切り出し、エラー文言を一元化した。decrypt_safeは検証後に既存のオーバーフロー回避ロジック(i32へ拡張して正規化)を維持するように整理した。src/caesar_cipher.rs。Testing
cargo testで実行し、全テストが成功しました(すべてのテストパス)。Codex Task