Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
decrypt_safeが復号処理を個別に行っており、decrypt側の修正が自動反映されない懸念があるため、復号ロジックを一箇所に集約する目的です。Description
decrypt_safeの入力検証後の処理をOk(decrypt(text, shift))に置き換え、docコメントに「内部的にdecryptを利用する」旨を追記しました。Testing
cargo testを実行し、ユニットテスト／統合テスト／ドキュメントテストを含む全自動テストが成功しました（全テスト通過）。Codex Task