Skip to content

Conversation

@Franky1
Copy link
Contributor

@Franky1 Franky1 commented Aug 25, 2025

  • updated the LICENSE to an "official" recognised text
  • added license badge in README.md
  • markdown linting of README.md
  • added some emojis to headers in README.md

@mrjbq7
Copy link
Member

mrjbq7 commented Aug 26, 2025

Thank you. I'm not a huge fan of emojis, nor badges, but I'll merge this and see how I like it.

@mrjbq7 mrjbq7 merged commit a27cb6c into TA-Lib:master Aug 26, 2025
6 checks passed
@mrjbq7
Copy link
Member

mrjbq7 commented Aug 26, 2025

I might revert the emojis, they look terrible on PyPI:

https://pypi.org/project/TA-Lib/0.6.6/

Unless you have some thoughts on how to fix that

@mrjbq7
Copy link
Member

mrjbq7 commented Aug 26, 2025

Maybe better to paste the emojis in directly?

@Franky1
Copy link
Contributor Author

Franky1 commented Aug 26, 2025

Yeah, seems that they are not rendered on pypi...
Then indeed better paste them in directly and not using shortcodes.
Should i fix it with a pull request?

@mrjbq7
Copy link
Member

mrjbq7 commented Aug 26, 2025 via email

@Franky1
Copy link
Contributor Author

Franky1 commented Aug 26, 2025

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants