fix: article image alignment and sizing #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given an article main image of thumbnail size with no set width, Then that image should not be shrunk less than width of content.
Given a news feed image of thumbnail size with large width, Then that image should not be shrunk less if space is available. BUG: If on grid layout (e.g. narrow screen), 300 width image too narrow.
…tching-on-wide-screen
There is only one column. Value of grid-template-areas illustrates that. New elements are added as row.
(or narrow list layout)
The removed value is always (i.e. at every screen, by every use case) override by grid-template-columns.
wesleyboar
changed the title
wesleyboar
added a commit
that referenced
this pull request
Jan 8, 2026
## Overview Minimally style the news layout options form. ## Related - helps when testing #1050 ## Changes - **changed** markup ## Testing 0. Open a News feed page. 1. Remove `hidden` attribute from form. 2. Click form options. 3. Verify news layout changes (on wide screen). ## UI | before | after | | - | - | | <img width="310" height="430" alt="news layout form BEFORE" src="https://github.com/user-attachments/assets/7bbfd924-6754-40ac-92c5-440e6fe158fb" /> | <img width="310" height="430" alt="news layout form AFTER" src="https://github.com/user-attachments/assets/dea7ce3a-e350-436f-aba2-faa74798c00d" /> |
…tching-on-wide-screen
wesleyboar
deleted the
fix/full-width-article-main-image-not-stretching-on-wide-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Important
To Do
- RT #38551 task #5
- feat: news media offset via core-styles mixin #1059
Fix alignment and size of:
Related
Changes
news-article-page__media--slim-context→…--layout-centernews-article-page__media--wide-context→…--layout-float…--layout-centerto be used only if main image thumb. opt. has0widthnews-article-page__media--…x-news.cssdjango.cms.blog.app.page.cssdata-widthdata-heightTesting
Given an article main image of thumbnail size with width = 0:
that image should be no wider than 50%.
that image should shrink to fit item.
that image should shrink to fit item.
that image should shrink to fit item.
Given an article main image of thumbnail size with width > 0:
that image width should define media grid cell width.
that image should grow to fit item.
that image should grow to fit item.
that image should grow to fit item.
UI
Skipped.
Footnotes
I.e. use a Thumbnail Option with
widthof0. ↩ ↩2 ↩3 ↩4This is a secret layout. Unhide the
#layout-choice-formelement to reveal the layout options. ↩