Skip to content

GH-93, GH-142, GH-133: Article List Plugins & Styles #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesleyboar wants to merge 126 commits into from
Closed

GH-93, GH-142, GH-133: Article List Plugins & Styles #279

wesleyboar wants to merge 126 commits into from

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 12, 2021 •
edited
Loading

Closed in favor of a PR that does not include "Revert" commits:

("Revert" commits could undo work from main if PRs that (desirably) have those commits were to be merged before this PR.)

wesleyboar added 30 commits April 12, 2021 18:46
@wesleyboar
GH-73: WIP Blockquote Plugin from Greet Plugin
6d69a56
@wesleyboar
GH-73: Fix model desc typo
4b5b5c7
@wesleyboar
Merge branch 'task/GH-67-tacc-sample-plugin' into task/GH-73-tacc-blo…
556024f 
…ckquote-plugin
@wesleyboar
Merge branch 'task/GH-67-tacc-sample-plugin' into task/GH-73-tacc-blo…
0a9ae0c 
…ckquote-plugin
@wesleyboar
GH-73: Update blockquote based on GH-67
0260226
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
49a8163
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
1c34b4b
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
aac4f5e
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
6f9440d
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
d2c554d
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
6ed391e
@wesleyboar
GH-73: Finish first version of blockquote plugin
6028f4a
@wesleyboar
GH-73: Finish blockquote plugin
c73532e
@wesleyboar
GH-73: Add offset plugin and offset to blockquote.
59db295 
- Add basic "Offset Content" plugin.
    - matches existing usage
    - lacks new feature (center alignment)
- Add support for Blockquote plugin inside text.
- Add support for offset option in Blockquote plugin.
@wesleyboar
GH-73: Blockquote: fix markup bug, post-dash space
f3dac48
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
4d5ee2b
@wesleyboar
GH-73: Update submodule to merge of main
eaa0a01
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
444cfc1
@wesleyboar
FP-1099: Test: Disable reindex on publish
580a7a5
@wesleyboar
Merge branch 'main' into task/GH-73-tacc-blockquote-plugin
3419a00
@wesleyboar
Quick: Update taccsite_custom to latest
22232f0
@wesleyboar
Merge branch 'main' into test/FP-1099-disabled-auto-search-reindex
c1bb7c7
@wesleyboar
GH-73: Move sample markup for blockquote into css
98d4199
@wesleyboar
FP-1099: Make Search a feature
7ebecb1 
Allow search to be disabled for Portal.
Allow indexing to be disabled for CMS.
@wesleyboar
FP-1099: Clarify Search feature value results
9ce83d2 
Default Value (i.e. falsy):
- Allow indexing for Portal CMS.
- Disallow indexing for SAD CMS.
@wesleyboar
GH-73: Collapse "Adv. Settings" for Offset… plugin
f972214
@wesleyboar
GH-73: Rename c-offset-content → o-offset-content
a7517d9 
- Texascale:
    - Have c-offset-content extend o-offset-content styles
    - Add comment for legacy support and deprecation of c-offset-content
@wesleyboar
GH-73: Rename c-offset-content model prop
4a55986
@wesleyboar
GH-73: Texascale: Deprecate Bootstrap blockquote
d63e6ad
@wesleyboar
GH-73: Support quotes in blockquote via CSS
10c5748
wesleyboar and others added 17 commits July 2, 2021 16:15
@wesleyboar
GH-93: Resolve GH-93 !!! comments
10e549c 
- Move cross-component styles to revived scope `s-article-list`.
- Remove `x-article-link-hover--gapless`.
@wesleyboar
GH-93: Do not use new .x-… mixins
7f0a76c 
- Some `.x-` mixins are in files updating during GH-93.
- Use `%-` instead of `.x-` and remove unused `.x-`.
@wesleyboar
GH-93: Frontera: Use old s-article-preview
7965b52
@wesleyboar
GH-93: Frontera: Cleanup s-home as GH-93 completes
96761a8
@wesleyboar
GH-93: Demote Deprecated Core Styles to Frontera
658ae01
@wesleyboar
GH-93: Consistent Line-Height for Docs & Events
50d6a9b
@wesleyboar
Merge pull request #264 from TACC/task/GH-93-article-list-styles
5a7bec6
@wesleyboar
GH-93: Update to get latest from taccsite_custom
9602dfc
@wesleyboar
Merge pull request #266 from TACC/task/GH-93-article-list-styles
09d691f 
Task/gh 93 article list styles
@wesleyboar
Hotfix: GH-93: Clearer & Accurate Date Logic
7c49db5 
Problem:
> unsupported operand type(s) for -: 'NoneType' and 'datetime.datetime'

Solution:
Fix bad logic that lead to None being assumed to be string and/or date.
@wesleyboar
Noop: GH-93: Consistent markup formatting for date
496f896
@wesleyboar
Merge pull request #268 from TACC/hotfix/GH-93-bad-date-logic
7c7294d
@wesleyboar
Hotfix: GH-93: 7c49db5 But Do It Right
ec860bf
@wesleyboar
Merge pull request #269 from TACC/hotfix/GH-93-bad-date-logic-round-2
1376eb9
@wesleyboar
Noop: Update comments (remove cruft)
328efb5
@wesleyboar
Quick: Submod: Merge main
a4ce4c3
@wesleyboar
Revert "FP-1099: …" (remove all of FP-1099 from dev branch)
9a498ab 
Revert "FP-1099: Clarify Search feature value results"

This reverts commit 9ce83d2.

Revert "FP-1099: Make Search a feature"

This reverts commit 7ebecb1.

Revert "FP-1099: Test: Disable reindex on publish"

This reverts commit 580a7a5.
@wesleyboar wesleyboar changed the title Task/gh 93 gh 142 gh 133 article list plugins and styles GH-93, GH-142, GH-133: Article List Plugins & Styles Jul 12, 2021
@wesleyboar
Revert #265 then #261 (other plugins) to (almost) isolate GH-93 changes
891e578 
NOTE: To revert #257 (GH-73, GH-66) is more difficult, so it is not reverted in this commit.

Revert "Merge pull request #265 from TACC/quick/clean-up-plugins-to-match-GH-93-plugins"

This reverts commit 2caa727, reversing
changes made to b76fda0.

Revert "Quick: Improve import caveat comments"

This reverts commit 66380a2.
@wesleyboar
Revert #257 (GH-73 & GH-66)
a196076 
Revert "Merge pull request #257 from TACC/task/GH-73-tacc-blockquote-plugin"

This reverts commit 0a82cd7, reversing
changes made to f48ecd2.
@wesleyboar
(Actually) Revert #261 (re-activate gen. plugins)
ef55e0c 
Revert "Merge pull request #261 from TACC/quick/support-plugins-unadulterated-by-bootstrap"

This reverts commit 3622661, reversing
changes made to 10aaf2f.
@wesleyboar wesleyboar force-pushed the task/GH-93-GH-142-GH-133-article-list-plugins-and-styles branch from 19e1357 to ef55e0c Compare July 13, 2021 00:41
@wesleyboar
Revert leftovers from 29e929e and b510c75
ec21f2a 
Moved to branch `task/GH-73-…` as 89ce2c6 and 4ea2e1c respectively.

A.k.a.:

- "(…)Noop: Existing Plugins: Comments, New Lines "
- "(…)Polish Existing Plugins"
@wesleyboar wesleyboar force-pushed the task/GH-93-GH-142-GH-133-article-list-plugins-and-styles branch from a3f2512 to ec21f2a Compare July 13, 2021 01:05
@wesleyboar wesleyboar mentioned this pull request Jul 13, 2021
Closed
@wesleyboar wesleyboar added the priority ▲ High priority label Jul 13, 2021
@wesleyboar
Copy link
Member Author

wesleyboar commented Jul 13, 2021

Closed in favor of #280.

@wesleyboar wesleyboar closed this Jul 13, 2021
@wesleyboar wesleyboar removed the priority ▲ High priority label Jul 13, 2021
@wesleyboar wesleyboar deleted the task/GH-93-GH-142-GH-133-article-list-plugins-and-styles branch July 13, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesleyboar