Skip to content

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 25, 2025

Overview / Changes

Pin CMS to latest.

I will start to tag latest (i.e. build main) when I release new CMS versions.

Details

I learned that if I build main, then image is tagged latest and as the latest version. So, I will build main knowing that it updates Core-Portal local dev.

Testing

  1. Create fresh Portal with fresh CMS.
  2. Verify no need to docs(Core-CMS#931): workaround CMS migrate fail #1096.

Note

If login to CMS gives "CSRF verification failed.", blame WP-897 not this PR.

UI

Skipped.

I learned that if I build `main`, then image is tagged `latest`  **and** as the latest version. So, I will build `main` knowing that it updates Core-Portal local dev.
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.47%. Comparing base (b27b0f5) to head (c49373c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   70.47%   70.47%           
=======================================
  Files         538      538           
  Lines       33380    33380           
  Branches     2967     2967           
=======================================
  Hits        23525    23525           
  Misses       9656     9656           
  Partials      199      199           
Flag Coverage Δ
javascript 72.67% <ø> (ø)
unittests 61.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wesleyboar wesleyboar marked this pull request as ready for review April 25, 2025 18:30
@wesleyboar wesleyboar requested a review from rstijerina April 25, 2025 18:30
@wesleyboar wesleyboar requested a review from taoteg May 5, 2025 16:27
@rstijerina rstijerina merged commit c320f82 into main May 7, 2025
6 checks passed
@rstijerina rstijerina deleted the feat/pin-latest-cms-tag branch May 7, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants