Open
Conversation
Contributor
|
CMakeLists for libdynet are mainly those from the original project. I'd prefer to keep them as they are (or to update them from source if needed). Can you post a PR withouth those changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using CMake targets, information about include directories, libraries, link flags,... is contained in the target and added to the dependencies.
One doubt I have:
Boost_LIBRARIESvariable already contains the target. If not, we should useBoost::program_options Boost::regex Boost:serialization(or the required targets for each library).As the other PR, I hope this is not breaking existing builds, if so, let me know how to reproduce them and I will work on these changes.