Redirect to Public Catalog for multi-button scenarios#62
Merged
Conversation
rmathew1011
approved these changes
Dec 3, 2025
kaladay
reviewed
Dec 3, 2025
kaladay
reviewed
Dec 3, 2025
Contributor
kaladay
left a comment
There was a problem hiding this comment.
Looks like github No longer allows it to be approved with comments?
Oh...the PR got merged while I was reviewing.
| hasCushing = true; | ||
| } | ||
| //when the user wants Cushing, grab the url of the first button that is for Cushing | ||
| if(redirectUrl == null && isCushing && wantsCushing && linkHref != null ) { |
Contributor
There was a problem hiding this comment.
This is just a suggestion.
These if conditon blocks could probably be combined, kind of like this:
// When the user wants Cushing, grab the url of the first button that is for Cushing.
// When the user doesn't want Cushing, grab the first button that isn't Cushing.
if (redirectUrl == null && linkHref != null && (!isCushing && !wantsCushing || isCushing && wantsCushing)) {
redirectUrl = buildRedirectUrl(linkHref);
break;
}
Comment on lines
+161
to
+166
| boolean bibIdIsUUID = true; | ||
| try { | ||
| bibIdIsUUID = (UUID.fromString(bibId).toString().equals(bibId)); | ||
| } catch (IllegalArgumentException e) { | ||
| bibIdIsUUID = false; | ||
| } |
Contributor
There was a problem hiding this comment.
This is just a suggestion.
The initialization is meaningless here.
Why not just default it to false and then the catch can be empty?
boolean bibIdIsUUID = false;
try {
bibIdIsUUID = (UUID.fromString(bibId).toString().equals(bibId));
} catch (IllegalArgumentException e) {
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the redirect endpoint and there are multiple GIFM options, redirect to the public catalog so the user can select the appropriate option.
This has been thoroughly tested in pre-production by the Discovery and GIFM teams over the last three months.